Clean up MCP sessions on delete#27
Merged
Merged
Conversation
lucarlig
force-pushed
the
user/luca/mcp-session-delete-cleanup
branch
from
June 2, 2026 13:01
8f7a9a7 to
dba60c8
Compare
lucarlig
force-pushed
the
user/luca/mcp-session-delete-cleanup
branch
from
June 3, 2026 08:46
dba60c8 to
65ca993
Compare
Signed-off-by: lucarlig <luca.carlig@ibm.com>
lucarlig
force-pushed
the
user/luca/mcp-session-delete-cleanup
branch
3 times, most recently
from
June 3, 2026 13:58
d53aa18 to
eab6832
Compare
Signed-off-by: lucarlig <luca.carlig@ibm.com>
lucarlig
force-pushed
the
user/luca/mcp-session-delete-cleanup
branch
from
June 3, 2026 14:17
eab6832 to
3e5387f
Compare
dawid-nowak
suggested changes
Jun 3, 2026
lucarlig
force-pushed
the
user/luca/mcp-session-delete-cleanup
branch
4 times, most recently
from
June 3, 2026 16:05
1ad0d13 to
a570c24
Compare
lucarlig
force-pushed
the
user/luca/mcp-session-delete-cleanup
branch
from
June 4, 2026 08:09
a570c24 to
e5dbcb3
Compare
Signed-off-by: lucarlig <luca.carlig@ibm.com>
lucarlig
force-pushed
the
user/luca/mcp-session-delete-cleanup
branch
from
June 4, 2026 08:11
e5dbcb3 to
7db1d3c
Compare
dawid-nowak
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splits MCP session DELETE cleanup out of the larger session/SSE work so this PR stays focused.
This PR:
tower-layersession-id layer with Axum middleware state so DELETE can run cleanup after RMCP handles the requestMcp-session-idoptional; requests without the header pass through, including DELETESessionIdextensions when the header is present, then usesmatch request.method()to run DELETE cleanup only after a successful downstream responsetower-layerdependencyVerification:
cargo fmt --all --checkcargo clippy --locked --workspace --all-targets -- -D warningscargo test --locked --workspacefmt,clippy,cargo-deny,cargo-shear,test,build,bench