Skip to content

ManifestProvenance: say why build_git_sha is absent (closes #100) #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ualtinok merged 1 commit into from
Sep 17, 2026
Merged

ManifestProvenance: say why build_git_sha is absent (closes #100) #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions crates/subc-control/tests/golden_json.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,6 +405,7 @@ fn client_control_responses() -> Vec<(&'static str, ClientControlResponse)> {
build_git_sha: Some(
"0123456789abcdef0123456789abcdef01234567".to_string(),
),
build_git_sha_absence_reason: None,
build_lock_digest: Some(
"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"
.to_string(),
Expand Down Expand Up @@ -494,6 +495,7 @@ fn client_control_responses() -> Vec<(&'static str, ClientControlResponse)> {
build_git_sha: Some(
"fedcba9876543210fedcba9876543210fedcba98-dirty".to_string(),
),
build_git_sha_absence_reason: None,
build_lock_digest: Some(
"cccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccc"
.to_string(),
Expand Down
2 changes: 1 addition & 1 deletion crates/subc-core/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "subc-core"
version = "0.17.45"
version = "0.17.47"
edition = "2021"
license = "MIT"
publish = false
Expand Down
1 change: 1 addition & 0 deletions crates/subc-core/src/bin/fake-aft-stub.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1304,6 +1304,7 @@ fn manifest_provenance() -> Option<ManifestProvenance> {
}
Some(ManifestProvenance {
build_git_sha: build_commit,
build_git_sha_absence_reason: None,
build_lock_digest,
wire_crate_version: wire_crate_version
.or_else(|| Some(SUBC_PROTOCOL_CRATE_VERSION.to_string())),
Expand Down
1 change: 1 addition & 0 deletions crates/subc-core/tests/catalog_update.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ async fn catalog_update_refreshes_catalog_without_disrupting_bound_routes() {
let mut module = connect_endpoint(&server, "module").await;
let provenance = ManifestProvenance {
build_git_sha: Some("0123456789abcdef0123456789abcdef01234567".to_string()),
build_git_sha_absence_reason: None,
build_lock_digest: Some("lock-digest".to_string()),
wire_crate_version: Some("0.13.0".to_string()),
store_schema_version: Some("3".to_string()),
Expand Down
1 change: 1 addition & 0 deletions crates/subc-core/tests/provenance.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,7 @@ async fn supervisor_provenance_reports_declared_and_observed_module_facts() {
// leakage sweep below.
let ManifestProvenance {
build_git_sha,
build_git_sha_absence_reason: _,
build_lock_digest,
wire_crate_version,
store_schema_version,
Expand Down
1 change: 1 addition & 0 deletions crates/subc-mcp/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1951,6 +1951,7 @@ fn manifest_output_keeps_provenance_in_the_static_manifest_object() {
let mut manifest = supervision_manifest(MANIFEST_MODULE_ID.to_string());
manifest.provenance = Some(subc_protocol::manifest::ManifestProvenance {
build_git_sha: Some("0123456789abcdef0123456789abcdef01234567".to_string()),
build_git_sha_absence_reason: None,
build_lock_digest: None,
wire_crate_version: Some("0.13.0".to_string()),
store_schema_version: None,
Expand Down
2 changes: 1 addition & 1 deletion crates/subc-protocol/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "subc-protocol"
version = "0.19.1"
version = "0.19.2"
edition = "2021"
publish = true
description = "Shared wire contract for subc <-> modules: the 21-byte envelope, the Frame (header + opaque body), channel-0 control bodies, route.bind/RouteTarget session shapes, and the capability manifest. Single source of truth, depended on by subc-core and AFT."
Expand Down
Loading