fix(cuda): advertise enforced embedding batch limits for owned-cuda - #21
Merged
Merged
Conversation
|
Verified and landing. Confirmed at source that the advertised values are the enforced ones: the batch planner clamps every engine to Thanks for tracing the consumer failure end to end — a producer omission that reads as "no error" on our side and "no embedding calls" on AFT's is exactly the kind of silent gap worth a regression test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
recommended_batch_for_enginereturnsNoneforowned-cuda, somodels.listomitsrecommended_batchfor CUDA models. Consumers that require the field reject the envelope (AFT's batch pager refuses discovery — reproduced end-to-end here: AFT failed model discovery with no usable recommended_batch rows/token_budget, and a normal semantic search made zero embedding calls as a result).This is the same omission PR #19's review surfaced; it was kept out of #19 deliberately. Alfonso's
4a03d6bflanding coversowned-metal+ane; the owned-cuda arm fell through.Change
owned-cudajoins theowned-metalarm — rows=MAX_ENGINE_BATCH_ITEMS(8), token_budget=DEFAULT_ENGINE_BATCH_TOKEN_BUDGET(3072). These are the module-enforced limits, matching what the worker actually admits; no invented values.recommended_batch_policy_uses_engine_constants_and_omits_unknown_adviceto assert the CUDA arm serializes with those exact constants (fails pre-fix, passes post-fix).Verification
cargo test -p synapse-module --lib recommended_batch— 1 passed (fails on master: no CUDA arm).cargo clippy -p synapse-module --lib -- -D warningsclean;cargo fmt --all -- --checkclean.refund_cancelled_purchase, semantic_score 0.5837) only after the deployed module carried this arm; pre-fix it refused discovery.Cargo.lockuntouched.Real consumer proof already posted in the #19 thread (issuecomment-5715898282); this PR is the upstreamable form.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Fixes CUDA models missing
recommended_batchinmodels.listbecauserecommended_batch_for_enginereturnedNoneforowned-cuda. The engine now returns the same enforced batch limits asowned-metal(8 rows, 3072 token budget), so consumers that require the field no longer reject the envelope.Written for commit cefe807. Summary will update on new commits.