Skip to content

enhance sensitive field checks to include SecretStringSliceCSV#7586

Merged
SungJin1212 merged 1 commit into
cortexproject:masterfrom
SungJin1212:add-SecretStringSliceCSV-regression-test
Jun 17, 2026
Merged

enhance sensitive field checks to include SecretStringSliceCSV#7586
SungJin1212 merged 1 commit into
cortexproject:masterfrom
SungJin1212:add-SecretStringSliceCSV-regression-test

Conversation

@SungJin1212

Copy link
Copy Markdown
Member

This PR enhances the test coverage for configuration fields that may contain sensitive information, ensuring that all such fields use appropriate masking types rather than plain strings or string slices.

Which issue(s) this PR fixes:
Fixes #7582

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]
  • docs/configuration/v1-guarantees.md updated if this PR introduces experimental flags

Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
@dosubot dosubot Bot added go Pull requests that update Go code type/tests labels Jun 4, 2026
@SungJin1212 SungJin1212 requested a review from friedrichg June 15, 2026 03:55

@friedrichg friedrichg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Jun 17, 2026
@SungJin1212 SungJin1212 merged commit b09efdc into cortexproject:master Jun 17, 2026
68 of 69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go Pull requests that update Go code lgtm This PR has been approved by a maintainer size/M type/tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

V03 /config secret-leak regression test misses SecretStringSliceCSV (sign_write_requests_keys) coverage

2 participants