misra.py: Fix R12.4 and R13.1 crashes on large initializer lists#2410
Merged
danmar merged 1 commit intoDec 1, 2019
Merged
Conversation
Fixed usage of hasSideEffectsRecursive which was causes crashes of rules 12.4 and 13.1. Add more tests for these rules. See trac ticket: https://trac.cppcheck.net/ticket/9487
versat
reviewed
Nov 30, 2019
versat
left a comment
versat
left a comment
Collaborator
There was a problem hiding this comment.
These huge arrays in the test file do not look nice. But I admit that I have no better idea and not adding the tests is IMO also not a solution.
Maybe it is useful to create an extra test file for such crash tests, but that has to be discussed. Maybe it is the best for now to leave it as it is in this PR.
Collaborator
Yes I agree. If we get lots of stability tests it might be better to separate them and put them in separate files. |
Collaborator
|
for now I allow that this testing is added in the "master misra test file". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed usage of
hasSideEffectsRecursivewhich was causes crashes of rules 12.4 and 13.1.These changes don't solve problem with recursive functions completely, but at least I can't found any real cases which will crash
misra.pyon recursive calls. Scanning dump files described in trac ticket don't cause crash anymore.See trac ticket: https://trac.cppcheck.net/ticket/9487