moved fileSettings out of Settings - #5608
Merged
Merged
Conversation
Collaborator
Author
|
Needs #5604 merged first. The TODOs will be addressed in a follow-up PR which increases the test coverage. I also filed https://trac.cppcheck.net/ticket/12133 for the one about the whole program analysis (lack of) usage of the addons. I also hope we might be able to merge these two different file lists in the future. |
firewave
force-pushed
the
proh-clean-2-2
branch
2 times, most recently
from
November 2, 2023 18:49
c057890 to
6d0a46b
Compare
firewave
marked this pull request as ready for review
November 2, 2023 18:49
firewave
marked this pull request as draft
November 2, 2023 18:49
firewave
force-pushed
the
proh-clean-2-2
branch
from
November 2, 2023 19:18
6d0a46b to
cc823f3
Compare
firewave
force-pushed
the
proh-clean-2-2
branch
from
November 2, 2023 19:54
cc823f3 to
9dcc4da
Compare
firewave
marked this pull request as ready for review
November 2, 2023 20:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved the
FileSettingsout of theSettingsand pass them around explicitly. They can never be specified at the same time and are used exclusively. The code hasn't been fully adjusted to reflect this as this is only the refactoring without any functional changes.