Skip to content

Expand template argument type deduction #8688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pfultz2 wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Expand template argument type deduction #8688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
2c68b09
Add template type deduction
Jul 2, 2026
eecd903
Simplify
Jul 2, 2026
a43039a
Use a forward walk
Jul 2, 2026
695de6e
Handle global function template called from a class scope
Jul 2, 2026
b60e55e
Improve member functions
Jul 2, 2026
de77bc6
Handle late class members
Jul 2, 2026
90c62dc
Handle overloading better
Jul 2, 2026
5ad01ad
Simplify and add unit tests
Jul 2, 2026
965281d
Improve comments
Jul 2, 2026
d966681
Avoid output params
Jul 2, 2026
f64190d
Format
Jul 2, 2026
81da87b
Use stl algorithm
Jul 2, 2026
9b554ac
Format
Jul 2, 2026
35e830a
Fix selfcheck
Jul 3, 2026
770eeb9
Remvoe unnecessary move
Jul 3, 2026
0e81fca
Add test for 13630
Jul 3, 2026
e87f8d7
Format
Jul 3, 2026
9933641
Suppress unmatchedSuppression
Jul 4, 2026
6dab97d
Merge
Jul 5, 2026
a6ded13
Suppress unmatched suppression warnings with template instantiation
Jul 7, 2026
7f3645f
Fix cppcheck debug warning
Jul 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .selfcheck_suppressions
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ autoNoType:gui/*.cpp
autoNoType:test/*.cpp
autoNoType:tools/triage/mainwindow.cpp
# ticket 11631
templateInstantiation:test/testutils.cpp
templateInstantiation

@firewave firewave Jul 3, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to have an entry for each file it occurs in so we would at least partially detect future regressions. Heck, we should probably move this to the source instead so we have actual individual suppressions.

Since the scope has widened additional tickets probably need to be filed.

@pfultz2 pfultz2 Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well we need to suppress it everytime we use functions like contains or calculate, and we are a long ways from being able to instantiate those functions. This isnt catching any errors and just adding burden. I think it would be better as a seperate report like daca.

@firewave firewave Jul 3, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. It is just a debug warning (those are tracked in daca). Still a new ticket for one of the additional cases would be good for tracking.


naming-varname:externals/simplecpp/simplecpp.h
naming-privateMemberVariable:externals/simplecpp/simplecpp.h
Expand Down
2 changes: 2 additions & 0 deletions cli/cmdlineparser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1653,6 +1653,8 @@ CmdLineParser::Result CmdLineParser::parseFromArgs(int argc, const char* const a
mSettings.unmatchedSuppressionFilters.emplace_back("misra-*");
if (!mSettings.premium)
mSettings.unmatchedSuppressionFilters.emplace_back("premium-*");
if (!mSettings.debugwarnings)
mSettings.unmatchedSuppressionFilters.emplace_back("templateInstantiation");

if (inputAsFilter) {
mSettings.fileFilters.insert(mSettings.fileFilters.end(), mPathNames.cbegin(), mPathNames.cend());
Expand Down
4 changes: 4 additions & 0 deletions lib/checkclass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2334,6 +2334,10 @@ bool CheckClassImpl::isMemberVar(const Scope *scope, const Token *tok) const
if (Token::Match(tok->tokAt(-3), "%name% ) . %name%")) {
tok = tok->tokAt(-3);
again = true;
} else if (Token::Match(tok->tokAt(-2), ") . %name%")) {
// function call chain: the member is accessed through the return value
tok = tok->linkAt(-2)->previous();
again = true;
} else if (Token::Match(tok->tokAt(-2), "%name% . %name%")) {
tok = tok->tokAt(-2);
again = true;
Expand Down
Loading
Loading