feat(architecture): align package roles across catalog and policy - #2703
Conversation
|
Warning Review limit reachedNext included review available in 48 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (26)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
📊 Benchmark Results✅ All benchmarks passed
Updated: 2026-09-08T05:53:48.811Z · Commit: c86abc2 |
Summary
Public packages now have one canonical role in
docs/package-catalog.json: Kernel, Contracts, Plugins, Application, Profiles, or Tooling. Subtype, domain, runtime claims, maturity, certification, and spine membership remain separate. Historical inventory groups retain their certification scope.README role tables, the extension matrix, repository architecture policy, and the role map shipped with generated applications use that source. Missing or contradictory role metadata and generated-map drift fail repository checks. Kernel/Contracts cannot import concrete Plugins; generated Plugins can compose other Plugins. The desktop contract's stricter browser and manifest restrictions remain effective.
tx-drizzleis Plugins/provider andtelemetry-apiis Contracts/observability. Architecture and generated agent guidance preserve the separate Host, Transport, and Build Target responsibilities.Closes #2157
Validation
Elevated profile for metadata shared by documentation, dependency policy, and generated applications.
pnpm check: 27 passed, one not applicable.Evidence identity
Head:
c86abc2e75502ae9d29f09213c03aa2eb916b4ee.Validated base:
98fcaed613d648bde489686c5f1ae622f59070cd.Runtime metadata records existing compatibility claims; an explicit empty list means unclaimed support. This change does not introduce new runtime support.
Current assessed base:
1d120139878fa362578d665d213d0e93558addcd. Cumulative drift is non-interacting with canonical roles and generated architecture policy. The initial provider changes and separate inventory entry received independent review; later billing retry and workflow execution fixes retain package identities, role metadata, and dependency directions. The workflow registry change adds only recovery metadata. No rebase was required.CI validated merge candidate
fdb553e465388e66eaeb97def6df9d421f973142with basec2a26539a965065486813fda9462a0bae6d82212and the unchanged head. Its tree is57c6f63cdd09dce6914ed40152db0e68feb500f3. Downloaded core evidence proves inventory, catalog, architecture policy, and runtime policy pass on that exact candidate; publish-profile evidence has 34 passing checks and one not applicable. Subsequent base changes do not invalidate those role-contract assumptions.CI
All required checks pass:
validate,benchmark-gate,docs-sync-check, andrepository-contracts. Impact-selected companion, core verification, generated apps, package artifacts, coverage/security, Windows scaffold, split-validation shadow, documentation build and links also pass.Runs: CI, review companion, benchmark.
GitHub reports a clean, conflict-free PR. No requested changes, review requests, unresolved threads, or blocking issue comments remain. All ten uploaded screenshots were verified rendering in the published PR.
Visual evidence
Final documentation build. Pure copy and table changes; no interaction flow changed.