(feat) qol improvements for streaming api#20
Merged
Conversation
moved the creation of MSPC channel for looper/interface comms to the LooperStreamBuilder build() method to avoid the user having to manually pass the mpsc channel themselves.
because the struct just had 2 fields it felt eaiser to just move to a tuple it also makes the interaction with the return type easier because looper isn't nested like `looper.looper.send` for ex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved MPSC channel creation into the build() method on looper streamer this way the user doesn't have to actually create this themselves.
Fixes #17