Skip to content

change call_child_workflow to pass correct wf name to durabletask worker #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
berndverst merged 5 commits into from
Oct 31, 2023
Merged

change call_child_workflow to pass correct wf name to durabletask worker #616

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
40941b8
change call_child_workflow to pass correct wf name to durabletask worker
bkc Oct 11, 2023
fcf8a28
Merge branch 'master' into patch-1
berndverst Oct 31, 2023
08b428a
Merge branch 'master' into patch-1
berndverst Oct 31, 2023
1b74f64
Update ext/dapr-ext-workflow/dapr/ext/workflow/dapr_workflow_context.py
berndverst Oct 31, 2023
ef39b1c
Update ext/dapr-ext-workflow/dapr/ext/workflow/dapr_workflow_context.py
berndverst Oct 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ext/dapr-ext-workflow/dapr/ext/workflow/dapr_workflow_context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,8 @@ def call_child_workflow(self, workflow: Workflow, *,
def wf(ctx: task.OrchestrationContext, inp: TInput):
daprWfContext = DaprWorkflowContext(ctx)
return workflow(daprWfContext, inp)
# copy workflow name so durabletask.worker can find the orchestrator in its registry
wf.__name__ = workflow.__name__
return self.__obj.call_sub_orchestrator(wf, input=input, instance_id=instance_id)

@cgillum cgillum Oct 16, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While hacky, this feels like the right fix given the current limitations of the durabletask-python library. Ideally we add a parameter to call_sub_orchestrator that allows overriding the name so that callers don't need to be aware of the internal implementation details.

@DeepanshuA thoughts?

@berndverst berndverst Oct 31, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this and you can consider a better solution in a future release.

@berndverst berndverst Oct 31, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment line is too long. Please see Python style guide ;)


def wait_for_external_event(self, name: str) -> task.Task:
Expand Down