Skip to content

ENH: More uint types for torch#244

Merged
ev-br merged 1 commit into
data-apis:mainfrom
crusaderky:torch_uint
Jan 31, 2025
Merged

ENH: More uint types for torch#244
ev-br merged 1 commit into
data-apis:mainfrom
crusaderky:torch_uint

Conversation

@crusaderky

Copy link
Copy Markdown
Contributor

No description provided.

@ev-br ev-br left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense!

@ev-br

ev-br commented Jan 29, 2025

Copy link
Copy Markdown
Member

Note that due to the way automation is set up in this repository, Ci failures --- even if unrelated --- block merges and releases (hint hint).

  • clip failure is a flaky test, might disappear on a rerun (a better fix would be much appreciated of course)
  • dask's error, Original Message: Can not use auto rechunking with object dtype. We are unable to estimate the size in bytes of object data, is something new and probably due to recent dask effort

@crusaderky

Copy link
Copy Markdown
Contributor Author

@ev-br ev-br closed this Jan 31, 2025
@ev-br ev-br reopened this Jan 31, 2025
@ev-br

ev-br commented Jan 31, 2025

Copy link
Copy Markdown
Member

The change LGTM. It effectively bumps the torch requirement to >= 2.3, which is likely fine.

I'm going to carpe diem while the CI is green after #246 and press the green button.

Thanks @crusaderky

@ev-br ev-br merged commit 2eafb97 into data-apis:main Jan 31, 2025
@crusaderky crusaderky deleted the torch_uint branch January 31, 2025 11:42
@ev-br ev-br mentioned this pull request Feb 25, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants