Skip to content

[PLUGIN-1888] Skip field validation for compatiblity#587

Merged
psainics merged 1 commit into
data-integrations:developfrom
cloudsufi:patch/PLUGIN-1888
May 5, 2025
Merged

[PLUGIN-1888] Skip field validation for compatiblity#587
psainics merged 1 commit into
data-integrations:developfrom
cloudsufi:patch/PLUGIN-1888

Conversation

@psainics
Copy link
Copy Markdown

@psainics psainics commented May 2, 2025

https://cdap.atlassian.net/browse/PLUGIN-1888

Test

  • Make a pipeline mariadb 1.10.0 (hub version) source to sink
  • upgrade pipeline to new build
  • pipeline ran successfully

  • Hub version pipeline
    image

  • Hub version detected schema
    image

  • Pipeline upgrade

image
  • Successful run
    image

  • Data on BQ

image

Known Issue with maria db driver below 3.5.2 (https://cdap.atlassian.net/browse/PLUGIN-1889)

@psainics psainics added the build label May 2, 2025
@psainics psainics self-assigned this May 2, 2025
@psainics psainics marked this pull request as ready for review May 2, 2025 06:35
Schema.Field.of("double_column", Schema.nullableOf(Schema.of(Schema.Type.DOUBLE))),
Schema.Field.of("boolean_column", Schema.nullableOf(Schema.of(Schema.Type.BOOLEAN)))
);
private static final AbstractDBSource.DBSourceConfig mockConfig = new AbstractDBSource.DBSourceConfig() {
Copy link
Copy Markdown
Contributor

@itsankit-google itsankit-google May 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: TEST_CONFIG

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated !

@psainics psainics force-pushed the patch/PLUGIN-1888 branch from d42cde8 to 2a56874 Compare May 5, 2025 08:48
@psainics psainics merged commit 1cb60de into data-integrations:develop May 5, 2025
10 checks passed
@psainics psainics deleted the patch/PLUGIN-1888 branch May 5, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants