Skip to content

Use filer.Filer in bundle/deployer/locker#136

Merged
pietern merged 3 commits into
mainfrom
locker-filer
Dec 15, 2022
Merged

Use filer.Filer in bundle/deployer/locker#136
pietern merged 3 commits into
mainfrom
locker-filer

Conversation

@pietern

@pietern pietern commented Dec 14, 2022

Copy link
Copy Markdown
Contributor

Summary:

  • All remote path arguments for deployer and locker are now relative to root specified at initialization
  • The workspace client is now a struct field so it doesn't have to be passed around

@pietern

pietern commented Dec 14, 2022

Copy link
Copy Markdown
Contributor Author

@shreyas-goenka The comment diffs are caused by go1.19 formatting doc strings.

I'm following up by making our fmt job use 1.19 so it is consistent with anyone using 1.19 locally.

@pietern

pietern commented Dec 14, 2022

Copy link
Copy Markdown
Contributor Author

Manually ran the integration test and it succeeds.

@pietern

pietern commented Dec 14, 2022

Copy link
Copy Markdown
Contributor Author

Updated the formatter in #137 and rebased this change on top.

@shreyas-goenka shreyas-goenka left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Question about how well dbfs can work with dabs? Can you keep code assets for execution in dbfs or would have a more limited experience using DAB without files in workspace?

Comment thread bundle/deployer/deployer.go
Comment thread bundle/deployer/locker.go
@pietern

pietern commented Dec 15, 2022

Copy link
Copy Markdown
Contributor Author

Question about how well dbfs can work with dabs? Can you keep code assets for execution in dbfs or would have a more limited experience using DAB without files in workspace?

It would work fine. You need the workspace for notebooks. Other code can live wherever.

Without files in workspace we need an alternative place to put the deployment state file. It can either be an empty / uninitialized repo, or some path on DBFS, or something else altogether in the future. My intent is to not hardcode to any single approach because none of them will be available to all users.

@pietern pietern merged commit 32a37c1 into main Dec 15, 2022
@pietern pietern deleted the locker-filer branch December 15, 2022 16:16
denik pushed a commit that referenced this pull request May 20, 2026
Summary:
* All remote path arguments for deployer and locker are now relative to
root specified at initialization
* The workspace client is now a struct field so it doesn't have to be
passed around
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants