Use precomputed terraform plan for bundle deploy#1640
Merged
Conversation
…ction and modify all diagnostics paths to be relative to the bundle root path
Contributor
Author
|
Triggered a round of nightlies on this PR. |
andrewnester
approved these changes
Jul 31, 2024
Contributor
Author
|
Waiting for the nightlies to pass before merging. |
Contributor
Author
|
The test for deploying empty bundles failed. This is because we used to always run Fixed by handing the case of state file missing in the Triggering another round of the nightlies. |
Contributor
Author
|
The night are green now. |
andrewnester
added a commit
that referenced
this pull request
Jul 31, 2024
Bundles: * Add resource for UC schemas to DABs ([#1413](#1413)). Internal: * Use dynamic walking to validate unique resource keys ([#1614](#1614)). * Regenerate TF schema ([#1635](#1635)). * Add upgrade and upgrade eager flags to pip install call ([#1636](#1636)). * Added test for negation pattern in sync include exclude section ([#1637](#1637)). * Use precomputed terraform plan for `bundle deploy` ([#1640](#1640)).
Merged
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jul 31, 2024
Bundles: * Add resource for UC schemas to DABs ([#1413](#1413)). Internal: * Use dynamic walking to validate unique resource keys ([#1614](#1614)). * Regenerate TF schema ([#1635](#1635)). * Add upgrade and upgrade eager flags to pip install call ([#1636](#1636)). * Added test for negation pattern in sync include exclude section ([#1637](#1637)). * Use precomputed terraform plan for `bundle deploy` ([#1640](#1640)).
denik
pushed a commit
that referenced
this pull request
May 20, 2026
# Changes With #1413 we started to compute and partially print the plan if it contained deletion of UC schemas. This PR uses the precomputed plan to avoid double planning when actually doing the terraform plan. This fixes a performance regression introduced in #1413. # Tests Tested manually. 1. Verified bundle deployment still works and deploys resources. 2. Verified that the precomputed plan is indeed being used by attaching a debugger and removing the plan file right before the terraform apply process is spawned and asserting that terraform apply fails because the plan is not found.
denik
pushed a commit
that referenced
this pull request
May 20, 2026
Bundles: * Add resource for UC schemas to DABs ([#1413](#1413)). Internal: * Use dynamic walking to validate unique resource keys ([#1614](#1614)). * Regenerate TF schema ([#1635](#1635)). * Add upgrade and upgrade eager flags to pip install call ([#1636](#1636)). * Added test for negation pattern in sync include exclude section ([#1637](#1637)). * Use precomputed terraform plan for `bundle deploy` ([#1640](#1640)).
4 tasks
simonfaltum
added a commit
that referenced
this pull request
May 20, 2026
…cks.com (#5283) ## Why The discovery login flow (`databricks auth login` without `--host`) opens `https://login.databricks.com`. That host is hardcoded in the CLI, so there is no way to point the flow at a non-production login instance during testing or development. The SDK already exposes `u2m.WithDiscoveryHost` (added in databricks-sdk-go #1640, on the CLI's pinned v0.132.0). This PR wires it up. ## Changes **Before:** No way to override the discovery host. `databricks auth login` always opens `https://login.databricks.com`. **Now:** If `DATABRICKS_DISCOVERY_HOST` is set, the CLI passes it through to `u2m.WithDiscoveryHost(...)`. When unset, behavior is identical to before. The "Opening ... in your browser..." log line reflects the override host so it's clear which host is being opened. Intended for testing and development against non-production login instances; unset for normal use. ## Test plan - [x] New unit test `TestDiscoveryLogin_OverridesHostFromEnv` confirms the env var is read and the log message reflects the override host - [x] `go test ./cmd/auth/...` passes - [x] `./task checks` passes - [x] `./task lint-q` passes
TanishqDatabricks
pushed a commit
to TanishqDatabricks/cli
that referenced
this pull request
May 22, 2026
…cks.com (databricks#5283) ## Why The discovery login flow (`databricks auth login` without `--host`) opens `https://login.databricks.com`. That host is hardcoded in the CLI, so there is no way to point the flow at a non-production login instance during testing or development. The SDK already exposes `u2m.WithDiscoveryHost` (added in databricks-sdk-go databricks#1640, on the CLI's pinned v0.132.0). This PR wires it up. ## Changes **Before:** No way to override the discovery host. `databricks auth login` always opens `https://login.databricks.com`. **Now:** If `DATABRICKS_DISCOVERY_HOST` is set, the CLI passes it through to `u2m.WithDiscoveryHost(...)`. When unset, behavior is identical to before. The "Opening ... in your browser..." log line reflects the override host so it's clear which host is being opened. Intended for testing and development against non-production login instances; unset for normal use. ## Test plan - [x] New unit test `TestDiscoveryLogin_OverridesHostFromEnv` confirms the env var is read and the log message reflects the override host - [x] `go test ./cmd/auth/...` passes - [x] `./task checks` passes - [x] `./task lint-q` passes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
With #1413 we started to compute and partially print the plan if it contained deletion of UC schemas. This PR uses the precomputed plan to avoid double planning when actually doing the terraform plan.
This fixes a performance regression introduced in #1413.
Tests
Tested manually.