Encourage the use of root_path in production to ensure single deployment#1712
Merged
lennartkats-db merged 12 commits intoJan 13, 2025
Merged
Conversation
pietern
reviewed
Aug 28, 2024
Co-authored-by: Pieter Noordhuis <pcnoordhuis@gmail.com>
pietern
reviewed
Sep 6, 2024
lennartkats-db
force-pushed
the
cp-encourage-root-path
branch
2 times, most recently
from
742210c to
3973c50
Compare
lennartkats-db
force-pushed
the
cp-encourage-root-path
branch
from
3973c50 to
6ea5306
Compare
Contributor
Author
|
@pietern @andrewnester could you take another look at this PR? The remaining thread should be resolved: #1712 (comment) |
pietern
reviewed
Dec 2, 2024
lennartkats-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pietern
reviewed
Jan 2, 2025
| // report an error for them. | ||
| return diag.Warningf("target with 'mode: production' should " + advice) | ||
| } | ||
| return diag.Errorf("target with 'mode: production' must " + advice) |
Contributor
There was a problem hiding this comment.
For follow-up: the advice should be a multi-line string in the Detail field to render nicely. As is, it is shown as a single (wrapped) line. The warning case will light up in all cases where mode: production is used and the root path is not specified.
Also, this doc page should be updated https://docs.databricks.com/en/dev-tools/bundles/deployment-modes.html#production-mode as well and linked from the warning to explain why the warning is shown while users haven't changed anything.
pietern
approved these changes
Jan 2, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
lennartkats-db
requested review from
andrewnester,
denik and
shreyas-goenka
as code owners
Contributor
|
An authorized user can trigger integration tests manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This updates
mode: productionto allowroot_pathto indicate uniqueness. Historically, we requiredrun_asfor this, which isn't actually very effective for that purpose.run_asalso had the problem that it doesn't work for pipelines.This is a cherry-pick from #1387