Skip to content

Restore flags to original values on test completion#470

Merged
shreyas-goenka merged 3 commits into
mainfrom
cleanup-flag-defaults
Jun 14, 2023
Merged

Restore flags to original values on test completion#470
shreyas-goenka merged 3 commits into
mainfrom
cleanup-flag-defaults

Conversation

@shreyas-goenka

@shreyas-goenka shreyas-goenka commented Jun 13, 2023

Copy link
Copy Markdown
Contributor

Changes

This is necessary to avoid test interference.

Tests

Manually.

@shreyas-goenka

Copy link
Copy Markdown
Contributor Author

@shreyas-goenka

Copy link
Copy Markdown
Contributor Author

Needs more work, some other flags too have incompatible default values wrt to their set methods. See failing PR checks for reference

@shreyas-goenka shreyas-goenka requested a review from pietern June 13, 2023 22:22

@pietern pietern left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this LGTM!

Comment thread internal/helpers.go Outdated
@pietern pietern changed the title Restore flag values to original defaults once a test finishes running Restore flags to original values on test completion Jun 14, 2023
@shreyas-goenka shreyas-goenka merged commit 968489d into main Jun 14, 2023
@shreyas-goenka shreyas-goenka deleted the cleanup-flag-defaults branch June 14, 2023 12:53
@pietern pietern mentioned this pull request Jun 15, 2023
pietern added a commit that referenced this pull request Jun 15, 2023
## Changes

CLI:
* Add workspace import-dir command
([#456](#456)).
* Annotate generated commands with OpenAPI package name
([#466](#466)).
* Associate generated commands with command groups
([#475](#475)).
* Disable shell completions for generated commands
([#483](#483)).
* Include [DEFAULT] section header when writing ~/.databrickscfg
([#464](#464)).
* Pass through proxy related environment variables
([#465](#465)).
* Restore flags to original values on test completion
([#470](#470)).
* Update configure command
([#482](#482)).

Dependencies:
* Bump SDK to latest
([#473](#473)).
denik pushed a commit that referenced this pull request May 20, 2026
## Changes

This is necessary to avoid test interference.

## Tests

Manually.

---------

Co-authored-by: Pieter Noordhuis <pieter.noordhuis@databricks.com>
denik pushed a commit that referenced this pull request May 20, 2026
## Changes

CLI:
* Add workspace import-dir command
([#456](#456)).
* Annotate generated commands with OpenAPI package name
([#466](#466)).
* Associate generated commands with command groups
([#475](#475)).
* Disable shell completions for generated commands
([#483](#483)).
* Include [DEFAULT] section header when writing ~/.databrickscfg
([#464](#464)).
* Pass through proxy related environment variables
([#465](#465)).
* Restore flags to original values on test completion
([#470](#470)).
* Update configure command
([#482](#482)).

Dependencies:
* Bump SDK to latest
([#473](#473)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants