Skip to content

Make templates work for service with "accounts" in its name#505

Closed
pietern wants to merge 1 commit into
mainfrom
workspace-accounts-api-templ
Closed

Make templates work for service with "accounts" in its name#505
pietern wants to merge 1 commit into
mainfrom
workspace-accounts-api-templ

Conversation

@pietern

@pietern pietern commented Jun 21, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@pietern pietern requested a review from nfx June 21, 2023 08:23

@nfx nfx left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest making a change on the OpenAPI level, so that it's cleaner end-user UX.

to unblock other generation, i'd suggest adding this service to $excludes for now

pietern added a commit that referenced this pull request Jul 3, 2023
* Regenerate CLI commands
* Ignore `account-access-control-proxy` (see #505)
@pietern pietern mentioned this pull request Jul 3, 2023
pietern added a commit that referenced this pull request Jul 3, 2023
## Changes

* Regenerate CLI commands
* Ignore `account-access-control-proxy` (see #505)

## Tests

Unit and integration tests pass.
@pietern

pietern commented Jul 7, 2023

Copy link
Copy Markdown
Contributor Author

Excluded this service from generation in #540.

@pietern pietern closed this Jul 7, 2023
@pietern pietern deleted the workspace-accounts-api-templ branch July 7, 2023 13:09
denik pushed a commit that referenced this pull request May 20, 2026
## Changes

* Regenerate CLI commands
* Ignore `account-access-control-proxy` (see #505)

## Tests

Unit and integration tests pass.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants