acceptance: guard git-repo-init against running inside an existing repo#5281
Open
denik wants to merge 1 commit into
Open
acceptance: guard git-repo-init against running inside an existing repo#5281denik wants to merge 1 commit into
denik wants to merge 1 commit into
Conversation
git config silently writes to whatever repo CWD is in, so calling git-repo-init from inside an existing repo poisons that repo's config without any error signal. Co-authored-by: Isaac
Contributor
Waiting for approvalBased on git history, these people are best suited to review:
Eligible reviewers: Suggestions based on git history. See OWNERS for ownership rules. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
"git config" writes to whatever repo CWD is in, so calling git-repo-init from inside an existing repo poisons that repo's config without any error signal. I had my cli repo config messed up by an agent.
Co-authored-by: Isaac