Fix pydabs acceptance test regex to match v1.x bundle versions#5294
Merged
Conversation
The replacement regex only matched databricks-bundles==0.x.y, so after the v1.0.0 release the wheel version 1.0.0 slipped through unredacted and the recorded output no longer matched. Co-authored-by: Isaac
andrewnester
approved these changes
May 21, 2026
andrewnester
approved these changes
May 21, 2026
| Cloud = false | ||
|
|
||
| [[Repls]] | ||
| Old = '"databricks-bundles==0.\d+.\d+"' |
Contributor
There was a problem hiding this comment.
Do we have other places where we might do the same?
Contributor
Author
There was a problem hiding this comment.
This seemed to be the only test that failed on main, so I think not. Let's see if main goes back to green.
TanishqDatabricks
pushed a commit
to TanishqDatabricks/cli
that referenced
this pull request
May 22, 2026
…ricks#5294) The `acceptance/bundle/templates/pydabs/test.toml` replacement regex only matched `databricks-bundles==0.x.y`, so after the v1.0.0 release the wheel version `1.0.0` slipped through unredacted and the recorded output (`databricks-bundles==x.y.z`) no longer matched. Broaden the regex to `\d+\.\d+\.\d+` (and escape the dots) so any future version is normalized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
acceptance/bundle/templates/pydabs/test.tomlreplacement regex only matcheddatabricks-bundles==0.x.y, so after the v1.0.0 release the wheel version1.0.0slipped through unredacted and the recorded output (databricks-bundles==x.y.z) no longer matched.Broaden the regex to
\d+\.\d+\.\d+(and escape the dots) so any future version is normalized.