acceptance: forbid empty test.toml files#5297
Merged
Merged
Conversation
Adds tools/check_test_toml.py, wired into ./task checks, which fails if any acceptance/**/test.toml parses to an empty table (zero-byte or comment-only). Deletes 20 pre-existing offenders -- 4 zero-byte placeholders and 16 comment-only files. None of the comments in those files are relevant for the test. Co-authored-by: Isaac
denik
approved these changes
May 21, 2026
Contributor
denik
left a comment
denik
left a comment
There was a problem hiding this comment.
nit: personally I'd extend acceptance test runner to reject such configs instead of separate entry in taskfile.
Per review feedback: fail in DoLoadConfig when a test.toml has no settings, instead of a separate ./task checks entry. Co-authored-by: Isaac
TanishqDatabricks
pushed a commit
to TanishqDatabricks/cli
that referenced
this pull request
May 22, 2026
Fail any acceptance test whose `test.toml` parses to an empty table (zero-byte or comment-only). The check lives in the acceptance test runner's config loader. Deletes 20 pre-existing offenders -- 4 zero-byte placeholders and 16 comment-only files. None of the comments in those files are relevant for the test. This codifies a review comment that shows up from time to time and thereby removes ambiguity/overhead. This pull request and its description were written by Isaac.
janniklasrose
added a commit
that referenced
this pull request
May 27, 2026
Picked up from the main merge: - #5297 forbids empty test.toml files; delete the two comment-only ones. - modernize: replace NumField loop with sdkType.Fields() iteration. - testifylint: assert.Empty over assert.Equal(t, "", ...). Co-authored-by: Isaac
denik
pushed a commit
that referenced
this pull request
May 28, 2026
Fail any acceptance test whose `test.toml` parses to an empty table (zero-byte or comment-only). The check lives in the acceptance test runner's config loader. Deletes 20 pre-existing offenders -- 4 zero-byte placeholders and 16 comment-only files. None of the comments in those files are relevant for the test. This codifies a review comment that shows up from time to time and thereby removes ambiguity/overhead. This pull request and its description were written by Isaac.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fail any acceptance test whose
test.tomlparses to an empty table (zero-byte or comment-only). The check lives in the acceptance test runner's config loader. Deletes 20 pre-existing offenders -- 4 zero-byte placeholders and 16 comment-only files. None of the comments in those files are relevant for the test.This codifies a review comment that shows up from time to time and thereby removes ambiguity/overhead.
This pull request and its description were written by Isaac.