lakebox: tab completion for sandbox IDs and ssh-key hashes#5310
Open
akshaysingla-db wants to merge 1 commit into
Open
lakebox: tab completion for sandbox IDs and ssh-key hashes#5310akshaysingla-db wants to merge 1 commit into
akshaysingla-db wants to merge 1 commit into
Conversation
Wire `ValidArgsFunction` on every lakebox subcommand that takes a positional argument so shells with cobra completion sourced suggest real IDs instead of falling back to filename completion: - ssh / status / stop / start / delete / config / set-default — sandbox IDs - ssh-key delete — registered key hashes Surfaced through the existing `databricks completion bash|zsh|fish` subcommand. Completion is best-effort — silently returns no suggestions on any error so the shell stays usable. Stacked on top of #<PR-A-NUM> (start + ssh fail-fast) since `start` needs to participate in completion too. Co-authored-by: Isaac
Contributor
Waiting for approvalBased on git history, these people are best suited to review:
Eligible reviewers: Suggestions based on git history. See OWNERS for ownership rules. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wire
ValidArgsFunctionon every lakebox subcommand that takes a positional argument so shells with cobra completion sourced suggest real IDs instead of falling back to filename completion:Surfaced through the existing
databricks completion bash|zsh|fishsubcommand. Completion is best-effort — silently returns no suggestions on any error so the shell stays usable.Stacked on top of # (start + ssh fail-fast) since
startneeds to participate in completion too.Co-authored-by: Isaac
Changes
Why
Tests