ssh: propagate server logs when the bootstrap job fails#5552
Merged
Conversation
The bootstrap notebook now tees the SSH server's output and, when the server process exits non-zero, fails the run with the last 2000 bytes of server logs in the exception, which "ssh connect" prints via the existing failed-run path. Also fixes the SIGCHLD subreaper handler silently swallowing the server's exit status, which could report a failed server as a successful run. Co-authored-by: Isaac
anton-107
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
anton-107
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
Integration test reportCommit: a5d1273
26 interesting tests: 15 SKIP, 6 RECOVERED, 5 flaky
Top 20 slowest tests (at least 2 minutes):
|
anton-107
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
anton-107
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
Integration test reportCommit: 1bf3c34
473 interesting tests: 406 MISS, 44 FAIL, 8 RECOVERED, 7 KNOWN, 3 PANIC, 3 flaky, 2 SKIP
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
ssh connectbootstrap notebook now tees the SSH server's stdout/stderr (logs keep streaming live to the run page) and, when the server process exits non-zero, fails the run with the last 2000 bytes of server logs embedded in the exception. The CLI then prints that tail through the existing failed-run path (describeRunFailure).Popen.wait(), Python reported exit code 0, so a failed server could show up as a successful job run. Reaped statuses are now recorded and consulted.describeRunFailuretruncates the run outputErrorto the same 2000-byte cap as the trace, and skips it when the traceback already ends with it, so the log tail isn't printed twice.Why
When the server binary fails, the run output only carried
Command '[...]' returned non-zero exit status N— the server's actual logs were unreachable from the client because the Jobs API does not expose notebook-task stdout (RunOutput.Logsis unsupported for notebook tasks), leaving users to dig through the run page. Follow-up to #5456.Tests
describeRunFailure(log-tail dedupe betweenErrorandErrorTrace,Errortruncation);./task test-exp-sshpasses.RuntimeError: SSH server exited with code 7. Last server logs:followed by the captured stdout/stderr tail (printed once) and the run page URL. A regularssh connect(serverless) still connects, with logs streaming to the run page.No NEXT_CHANGELOG.md entry:
sshis an experimental command.This pull request and its description were written by Isaac.