Pause the passive CLI update-available notice#5613
Merged
Conversation
The once-per-day "new release available" notice (#5470) is unreleased: it merged after v1.3.0 and would first reach users in v1.4.0. Pause it before it ships by unwiring it from the root command, so the background GitHub fetch and the notice never run. The explicit databricks version --check command (#5469, shipped in v1.3.0) is unaffected. We are not confident the passive notice targets the right users yet: as written it would nag a fresh install (very likely already up to date) as readily as the long-lived, outdated environments we actually want to reach. Keep the implementation in libs/versioncheck so re-enabling is a small change once we settle on the targeting. Co-authored-by: Isaac
simonfaltum
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
simonfaltum
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
Integration test reportCommit: 2f0fafc
22 interesting tests: 15 SKIP, 7 KNOWN
Top 24 slowest tests (at least 2 minutes):
|
pietern
approved these changes
Jun 16, 2026
Collaborator
Integration test reportCommit: 2f28778
448 interesting tests: 311 MISS, 107 FAIL, 17 RECOVERED, 7 KNOWN, 3 PANIC, 2 SKIP, 1 flaky
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The CLI gained a passive, once-per-day "a new release is available" notice in #5470. It merged right after v1.3.0 was tagged, so it hasn't shipped to anyone yet; v1.4.0 would be its first release. This pauses it before that happens.
The notice is meant for people running an outdated CLI in a long-lived local environment. But as written it can't distinguish them from a brand-new install, which is almost always already up to date. So the person most likely to see the very first nudge is someone who just installed the CLI and has nothing to upgrade, while the background GitHub call runs for everyone. Until we have a way to target the case we actually care about, the safer default is off.
The explicit
databricks version --checkcommand (#5469, shipped in v1.3.0) is unaffected: users who want to check stay in control.Changes
Before: every interactive command started a background check against GitHub and could print an upgrade notice after the command finished.
Now: the passive notice is unwired from the root command, so neither the background fetch nor the notice runs. A normal command makes no call to GitHub.
StartBackgroundRefreshandNoticecalls (and the import) fromcmd/root/root.go.NEXT_CHANGELOG.mdentry, since the feature won't ship in 1.4.0.libs/versioncheckintact, with a//deadcode:allownote explaining the pause. Re-enabling is just restoring the two root-command calls once we settle on the targeting.Test plan
go build ./...go test ./libs/versioncheck/... ./cmd/root/... ./cmd/version/..../task fmt-q,./task lint-q, and./task checksclean (including the deadcode gate)This pull request and its description were written by Isaac.