Print modern pipeline update URL from bundle run#5632
Closed
radakam wants to merge 1 commit into
Closed
Conversation
The CLI emitted a legacy hash-fragment URL (#joblist/pipelines/<id>/updates/<id>) for pipeline updates. This switches to the modern path form (/pipelines/<id>/updates/<id>) for consistency with the rest of the CLI's workspace URLs and with the job run URL change in #5142, where the legacy fragment form was found not to resolve for non-admin users permitted to view the run. Add a PipelineUpdatePath builder mirroring JobRunPath and emit the modern path form from NewPipelineUpdateUrlEvent. See #5142.
radakam
force-pushed
the
issue-5142-pipeline-update-url
branch
from
3047dfa to
cb08628
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
bundle runnow prints the modern pipeline update URL (/pipelines/<id>/updates/<id>) instead of the legacy#joblist/pipelines/<id>/updates/<id>hash-fragment URL.PipelineUpdatePath(pipelineID, updateID)builder inlibs/workspaceurls, mirroringJobRunPath.NewPipelineUpdateUrlEventinstead of constructing the#joblistfragment inline.Why
The CLI historically emitted a legacy hash-fragment URL for pipeline updates. This switches to the modern path form for consistency with the rest of the CLI's workspace URLs and with the job run URL change in #5142, where the legacy fragment form was found not to resolve for non-admin users permitted to view the run.
See #5142.
Tests
TestPipelineUpdatePathunit test.run/dry-run/stopcommands to the modern URL form.