direct: Record the CLI that last wrote the deployment state - #6222
Merged
Merged
Conversation
Collaborator
Integration test reportCommit: 4b2f17d
9 interesting tests: 4 SKIP, 3 RECOVERED, 1 KNOWN, 1 FAIL
|
cli_version in resources.json kept the version of the CLI that created the state: every deploy wrote the current version into the WAL header, but replay copied only lineage and serial back, so the field never moved. Refresh it alongside the serial, which is the same condition (the state file is only persisted when the WAL carried entries). This matches the terraform engine, which updates its own cli_version on every deploy, and the field's documented meaning.
denik
force-pushed
the
denik/state_cli_version
branch
from
August 11, 2026 12:33
4f78708 to
4b2f17d
Compare
andrewnester
approved these changes
Aug 11, 2026
denik
enabled auto-merge
August 11, 2026 12:55
Collaborator
Integration test reportCommit: 9d5fd4e
34 interesting tests: 20 flaky, 6 FAIL, 5 RECOVERED, 2 SKIP, 1 KNOWN
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
cli_versioninresources.jsonkept the version of the CLI that created the state. Every deploywrote the current version into the WAL header, but replay copied only lineage and serial back into
the state, so the field never moved — a state deployed daily by the latest CLI still reported
whatever version first created it.
The terraform engine updates its own
cli_versionon every deploy, and the field is documented asthe version that last wrote the state, so this brings the direct engine in line with both.
It is refreshed alongside the serial, under the same condition: the state file is only persisted when
the WAL carried entries, so a deploy that commits nothing must not claim to have written one.