acc: fix Windows failures in prevent-destroy and shell/cmd - #6287
Merged
Merged
Conversation
Both assert an uploaded file count that is not stable on Windows. Add -qq so the count is not part of the golden.
ilyakuz-db
approved these changes
Aug 17, 2026
andrewnester
approved these changes
Aug 17, 2026
denik
enabled auto-merge
August 17, 2026 13:14
denik
disabled auto-merge
August 17, 2026 13:24
janniklasrose
pushed a commit
that referenced
this pull request
Sep 15, 2026
## Why Two tests assert `Files: N uploaded`, which is not stable on Windows: - `bundle/lifecycle/prevent-destroy` is the only test that redirects `bundle deploy` output away from `output.txt`, so nothing writes to `output.txt` between the two deploys. Its mtime stays put on Linux and macOS, but on Windows the last-write-time update on the still-open handle lands late and the file looks modified, giving `Files: 3` instead of `2`. Deterministic, both engines. - `bundle/artifacts/shell/cmd` only runs on Windows, so `-update` elsewhere skips it. #6264 took repls.json out of the synced tree and moved the four sibling shell tests from 6 to 5, leaving this one stale at 6. ## Changes Add `-qq` to those deploys. The count is noise in both: prevent-destroy asserts the `prevent_destroy` error, and shell/cmd asserts which shell ran the build via `out.shell.txt`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Two tests assert
Files: N uploaded, which is not stable on Windows:bundle/lifecycle/prevent-destroyis the only test that redirectsbundle deployoutput away from
output.txt, so nothing writes tooutput.txtbetween the twodeploys. Its mtime stays put on Linux and macOS, but on Windows the last-write-time
update on the still-open handle lands late and the file looks modified, giving
Files: 3instead of2. Deterministic, both engines.bundle/artifacts/shell/cmdonly runs on Windows, so-updateelsewhere skips it.acc: merge repls.json into ACC_REPLS and move it out of the test directory #6264 took repls.json out of the synced tree
and moved the four sibling shell tests from 6 to 5, leaving this one stale at 6.
Changes
Add
-qqto those deploys. The count is noise in both: prevent-destroy asserts theprevent_destroyerror, and shell/cmd asserts which shell ran the build viaout.shell.txt.