acc: fix DBR failures in dashboards syncroot tests - #6290
Merged
Merged
Conversation
ilyakuz-db
approved these changes
Aug 17, 2026
Both sync one level above the bundle root, so the uploaded file count depends on the environment. Add -qq so it is not part of the golden.
denik
force-pushed
the
denik/dashboards-syncroot-qq
branch
from
August 17, 2026 13:30
d16009c to
42fb007
Compare
Collaborator
Integration test reportCommit: 2a8fcd2
12 interesting tests: 4 flaky, 3 RECOVERED, 3 KNOWN, 2 SKIP
Top 50 slowest tests (at least 2 minutes):
|
janniklasrose
pushed a commit
that referenced
this pull request
Sep 15, 2026
## Why `dashboards/simple_syncroot` and `dashboards/simple_outside_bundle_root` set `sync.paths` to one level above the bundle root, so they sync the acceptance tmpdir's parent. Its contents differ per environment, so `Files: N uploaded` is not stable: the golden says 9, DBR reports 6. Both tests pass in the six plain integration envs and fail in the two `dbr` jobs, since #5720 added the line. ## Changes Add `-qq` to the deploy. The count is noise here — these tests assert dashboard path resolution via `lakeview get`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
dashboards/simple_syncrootanddashboards/simple_outside_bundle_rootsetsync.pathsto one level above the bundle root, so they sync the acceptance tmpdir'sparent. Its contents differ per environment, so
Files: N uploadedis not stable: thegolden says 9, DBR reports 6. Both tests pass in the six plain integration envs and fail
in the two
dbrjobs, since #5720 added the line.Changes
Add
-qqto the deploy. The count is noise here — these tests assert dashboard pathresolution via
lakeview get.