Fix secret scope permission level - #6299
Merged
Merged
Conversation
Without Values(), generated enum validation skipped permissions[*].level, so invalid levels passed validate --strict and only failed at deploy.
Multiple secret_scopes map keys made warning order non-deterministic across engines; keep the cases as ordered permissions on one scope instead.
errcode only records tolerated failures; musterr asserts validate --strict must fail.
radakam
marked this pull request as ready for review
August 18, 2026 08:36
Collaborator
Integration test reportCommit: d1a5b06
8 interesting tests: 4 SKIP, 3 KNOWN, 1 RECOVERED
Top 6 slowest tests (at least 2 minutes):
|
Add a changelog fragment, simplify the acceptance fixture, and align permission-level constant order with privilege rank.
denik
approved these changes
Aug 18, 2026
radakam
enabled auto-merge
August 18, 2026 10:34
janniklasrose
pushed a commit
that referenced
this pull request
Sep 15, 2026
## Changes Add `Values()` on `SecretScopePermissionLevel` so generated enum validation covers the field, matching other resource permission levels. ## Why Invalid `secret_scopes` permission levels (e.g. `12`, `fuzz_badlevel`) passed `bundle validate --strict`, then failed at deploy in direct mode when collapsing ACLs. _Found by fuzz testing._ ## Tests Acceptance: `TestAccept/bundle/validate/secret_scope_invalid_permission_level` (warns on invalid `secret_scopes` permission levels (12, fuzz_badlevel); fails with `--strict`).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add
Values()onSecretScopePermissionLevelso generated enum validation covers the field, matching other resource permission levels.Why
Invalid
secret_scopespermission levels (e.g.12,fuzz_badlevel) passedbundle validate --strict, then failed at deploy in direct mode when collapsing ACLs.Found by fuzz testing.
Tests
Acceptance:
TestAccept/bundle/validate/secret_scope_invalid_permission_level(warns on invalidsecret_scopespermission levels (12, fuzz_badlevel); fails with--strict).