Conversation
30b0188 to
2f38bce
Compare
2f38bce to
80c5262
Compare
1de86ee to
ba03cd1
Compare
Approval status: pending
|
ba03cd1 to
637985d
Compare
|
|
||
| // InstallShim installs the Docker credential helper wrapper next to the Databricks CLI. | ||
| func InstallShim(databricksPath string) (ShimInstallResult, error) { | ||
| return installShimForGOOS(databricksPath, runtime.GOOS) |
There was a problem hiding this comment.
You can add shim_windows.go and shim_other.go and use build tags, unless you want to test the Windows paths on Linux.
There was a problem hiding this comment.
Yes, this is intentional so we can exercise Windows shim generation and lookup behavior on Linux CI. The actual cmd.exe execution tests remain Windows-only. Build tags would prevent that cross-platform coverage, so I prefer to keep the current structure if you don't object
68bacfd to
04f89b6
Compare
04f89b6 to
1e1a4ac
Compare
|
An authorized user can trigger integration tests manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
🥞 Stacked PR (generated by git ns)
Use this link to review incremental changes.
Changes
Add the experimental
databricks auth docker configure [PROFILE] --region REGIONcommand. It configures Docker's credential helper and installsdocker-credential-databricksbeside the running CLI: a shell shim on Unix and a.cmdshim on Windows. Both invokedatabricks auth docker tokenfor Docker'sgetoperation.Why
Docker needs a discoverable helper that requests a fresh workspace OAuth token for each Artifact Registry operation without persisting the token in Docker configuration.
Tests
go test ./libs/dockercredentials ./cmd/auth/docker ./cmd/auth ./cmd/root -count=1: passgo test ./acceptance -run 'TestAccept/cmd/auth/docker' -tail -test.v -count=1: pass0 issues), tidy, whitespace, dead-code, and changelog checks: pass./task test: 5,167 tests, 6 skipped, 43 unrelated bundle acceptance snapshot failures on the updated upstream baseThis PR was written by Codex.