Skip to content

Configure Docker authentication for Artifact Registry - #6336

Closed
yolocs wants to merge 2 commits into
databricks:mainfrom
yolocs:chen-shou_data/stack/dar-configure-docker-setup-2
Closed

yolocs wants to merge 2 commits into
databricks:mainfrom
yolocs:chen-shou_data/stack/dar-configure-docker-setup-2

Conversation

@yolocs

@yolocs yolocs commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

🥞 Stacked PR (generated by git ns)

Use this link to review incremental changes.


Changes

Add the experimental databricks auth docker configure [PROFILE] --region REGION command. It configures Docker's credential helper and installs docker-credential-databricks beside the running CLI: a shell shim on Unix and a .cmd shim on Windows. Both invoke databricks auth docker token for Docker's get operation.

Why

Docker needs a discoverable helper that requests a fresh workspace OAuth token for each Artifact Registry operation without persisting the token in Docker configuration.

Tests

  • go test ./libs/dockercredentials ./cmd/auth/docker ./cmd/auth ./cmd/root -count=1: pass
  • go test ./acceptance -run 'TestAccept/cmd/auth/docker' -tail -test.v -count=1: pass
  • Affected Go formatting and lint (0 issues), tidy, whitespace, dead-code, and changelog checks: pass
  • Windows and macOS CLI cross-builds: pass
  • ./task test: 5,167 tests, 6 skipped, 43 unrelated bundle acceptance snapshot failures on the updated upstream base

This PR was written by Codex.

@yolocs
yolocs force-pushed the chen-shou_data/stack/dar-configure-docker-setup-2 branch 2 times, most recently from 30b0188 to 2f38bce Compare August 20, 2026 22:38
@yolocs
yolocs force-pushed the chen-shou_data/stack/dar-configure-docker-setup-2 branch from 2f38bce to 80c5262 Compare August 31, 2026 17:17
@yolocs
yolocs force-pushed the chen-shou_data/stack/dar-configure-docker-setup-2 branch 5 times, most recently from 1de86ee to ba03cd1 Compare September 9, 2026 01:20
@yolocs
yolocs marked this pull request as ready for review September 9, 2026 16:05
@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Approval status: pending

/cmd/auth/ - needs approval

9 files changed
Suggested: @simonfaltum
Also eligible: @renaudhartert-db, @mihaimitrea-db, @tanmay-db, @Divyansh-db, @hectorcast-db, @parthban-db, @tejaskochar-db, @chrisst, @rauchy

General files (require maintainer)

23 files changed
Based on git history:

  • @simonfaltum -- recent work in cmd/auth/

Any maintainer (@andrewnester, @anton-107, @denik, @pietern, @shreyas-goenka, @simonfaltum, @renaudhartert-db, @janniklasrose, @lennartkats-db, @rugpanov, @rclarey) can approve all areas.
See OWNERS for ownership rules.

@yolocs
yolocs force-pushed the chen-shou_data/stack/dar-configure-docker-setup-2 branch from ba03cd1 to 637985d Compare September 11, 2026 16:46

// InstallShim installs the Docker credential helper wrapper next to the Databricks CLI.
func InstallShim(databricksPath string) (ShimInstallResult, error) {
return installShimForGOOS(databricksPath, runtime.GOOS)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add shim_windows.go and shim_other.go and use build tags, unless you want to test the Windows paths on Linux.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is intentional so we can exercise Windows shim generation and lookup behavior on Linux CI. The actual cmd.exe execution tests remain Windows-only. Build tags would prevent that cross-platform coverage, so I prefer to keep the current structure if you don't object

@yolocs
yolocs force-pushed the chen-shou_data/stack/dar-configure-docker-setup-2 branch 2 times, most recently from 68bacfd to 04f89b6 Compare September 14, 2026 21:29
@yolocs
yolocs force-pushed the chen-shou_data/stack/dar-configure-docker-setup-2 branch from 04f89b6 to 1e1a4ac Compare September 15, 2026 19:26
@github-actions

Copy link
Copy Markdown
Contributor

An authorized user can trigger integration tests manually by following the instructions below:

Trigger:
go/deco-tests-run/cli

Inputs:

  • PR number: 6336
  • Commit SHA: 1e1a4acad48f6d3d5e62c68638b15c135e637db2

Checks will be approved automatically on success.

@pietern

pietern commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Superseded by #6700, recreated on a branch in this repo (not a fork) so CI runs. Stacked on #6699; same content, authorship preserved.

@pietern pietern closed this Sep 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants