Remove orphaned vfs.Overlay in-memory filesystem - #6637
Merged
Merged
Conversation
Added in #6110 to inject generated files into the bundle sync root for AI Runtime code_source_path. Its only caller was removed in #6494, which packages the code_source as a tgz artifact instead of a sync overlay, leaving Overlay and its tests reachable only from their own unit tests. deadcode -test never flagged this: the tests kept it "live". Found by running reachability without test roots. Co-authored-by: Isaac <no-reply@databricks.com>
denik
enabled auto-merge
September 11, 2026 14:10
Collaborator
Integration test reportCommit: 1bec84e
15 interesting tests: 14 flaky, 1 RECOVERED
Top 3 slowest tests (at least 2 minutes):
|
janniklasrose
approved these changes
Sep 11, 2026
janniklasrose
pushed a commit
that referenced
this pull request
Sep 15, 2026
`vfs.Overlay` returned a `Path` that served in-memory files on top of a real tree. It was added in #6110 (Aug 2026) to inject generated files into the bundle sync root for AI Runtime `code_source_path`. Its only caller was removed in #6494 (Sep 2026), which packages the `code_source` as a tgz artifact instead of a sync overlay. Since then `Overlay` (and its whole `overlayPath`/`memFile` machinery) has been reachable only from its own unit tests. `deadcode -test ./...` doesn't catch this because the test suite keeps it "live"; it surfaces only when reachability is computed without test roots. This pull request and its description were written by Isaac. Co-authored-by: Isaac <no-reply@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vfs.Overlayreturned aPaththat served in-memory files on top of a real tree. It was added in #6110 (Aug 2026) to inject generated files into the bundle sync root for AI Runtimecode_source_path.Its only caller was removed in #6494 (Sep 2026), which packages the
code_sourceas a tgz artifact instead of a sync overlay. Since thenOverlay(and its wholeoverlayPath/memFilemachinery) has been reachable only from its own unit tests.deadcode -test ./...doesn't catch this because the test suite keeps it "live"; it surfaces only when reachability is computed without test roots.This pull request and its description were written by Isaac.