Treat already-gone deletes as state-only cleanup in plan/deploy output - #6675
Merged
Merged
Conversation
denik
force-pushed
the
denik/gone-count
branch
2 times, most recently
from
September 14, 2026 14:49
7789897 to
d5bd04e
Compare
denik
marked this pull request as ready for review
September 14, 2026 14:50
denik
enabled auto-merge
September 14, 2026 14:51
Collaborator
Integration test reportCommit: 40611fe
Top 6 slowest tests (at least 2 minutes):
|
denik
force-pushed
the
denik/gone-count
branch
2 times, most recently
from
September 15, 2026 08:36
1621aa9 to
97f6510
Compare
A Delete entry marked Gone (the resource is already missing remotely) only drops the stale state entry — no backend call — just like a StateOnly delete. Report it that way consistently: omit it from the `bundle plan` and `bundle deploy` action listings and from the resource counts, matching what `bundle destroy` already does. Previously plan/deploy listed and counted such deletes while destroy did not. Co-authored-by: Isaac <no-reply@databricks.com>
denik
force-pushed
the
denik/gone-count
branch
from
September 15, 2026 09:56
97f6510 to
40611fe
Compare
janniklasrose
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
A
Deleteentry markedGone(the resource is already missing remotely) only drops the stale state entry — no backend call — exactly like aStateOnlydelete. Report it consistently: omit it from thebundle planandbundle deployaction listings and from the resource counts, matching whatbundle destroyalready does.Why
The paths disagreed:
bundle destroyalready excluded already-gone resources from its "will be deleted" list and count, butbundle plan/deploystill listed and counted them as deletions. Fixing only the count would make deploy contradict itself ("Deleted jobs.foo" followed by "0 deleted"), so the listing and the count move together, matching the state-only-delete model.Tests
Acceptance goldens regenerated (
jobs/remote_delete/removed_from_config).This PR was written by Claude Code.