Conversation
The job_run resource no longer deletes runs (#6672), so the run cancel/delete handlers added for it in #6091 are unused: no acceptance test reaches them, and the air cancel test uses its own stub. Remove the handlers and the unit tests that only covered them. Co-authored-by: Isaac <no-reply@databricks.com>
denik
enabled auto-merge
September 15, 2026 08:30
Contributor
Waiting for approvalBased on git history, these people are best suited to review:
Eligible reviewers: Suggestions based on git history. See OWNERS for ownership rules. |
Collaborator
Integration test reportCommit: 43be7a7
Top 3 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Remove the testserver
runs/cancelandruns/deletehandlers (and the unit tests that only covered them). They were added in #6091 for the job_run resource'sDoDelete, which #6672 removed — so nothing reaches them anymore: no acceptance test hits these routes, and theaircancel test uses its own[[Server]]stub.Tests
Test-infra only.
libs/testserverunit tests and thejob_runs/air cancelacceptance suites pass.This pull request and its description were written by Isaac.