Skip to content

Fix uploading libraries when running bundle deploy --plan - #6682

Open
andrewnester wants to merge 2 commits into
mainfrom
fix/libraries-upload-plan
Open

andrewnester wants to merge 2 commits into
mainfrom
fix/libraries-upload-plan

Conversation

@andrewnester

Copy link
Copy Markdown
Contributor

Changes

Fix uploading libraries when running bundle deploy --plan

Why

Previously bundles skipped uploading libraries when reading from existing plan which made plans not really reusable

Tests

Covered by acceptance test

@github-actions

Copy link
Copy Markdown
Contributor

Approval status: pending

/acceptance/bundle/ - needs approval

8 files changed
Suggested: @denik
Also eligible: @shreyas-goenka, @pietern, @anton-107, @janniklasrose, @lennartkats-db

/bundle/ - needs approval

Files: bundle/phases/build.go
Suggested: @denik
Also eligible: @shreyas-goenka, @pietern, @anton-107, @janniklasrose, @lennartkats-db

/cmd/bundle/ - needs approval

Files: cmd/bundle/utils/process.go
Suggested: @denik
Also eligible: @shreyas-goenka, @pietern, @anton-107, @janniklasrose, @lennartkats-db

Any maintainer (@anton-107, @denik, @pietern, @shreyas-goenka, @simonfaltum, @renaudhartert-db, @janniklasrose, @lennartkats-db, @rugpanov, @rclarey) can approve all areas.
See OWNERS for ownership rules.

@andrewnester
andrewnester force-pushed the fix/libraries-upload-plan branch from bb2955d to ab5c4bd Compare September 15, 2026 10:16
Comment thread cmd/bundle/utils/process.go Outdated
@eng-dev-ecosystem-bot

eng-dev-ecosystem-bot commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator

Integration test report

Commit: d4c1c60

Run: 34966014404

Env 💚​RECOVERED ✅​pass 🙈​skip Time
💚​ aws linux 1 275 16 4:56
💚​ aws windows 1 277 14 3:39
💚​ azure linux 1 274 16 6:05
💚​ azure windows 1 276 14 4:45
💚​ gcp linux 1 275 16 6:06
💚​ gcp windows 1 277 14 4:05
Test Name aws linux aws windows azure linux azure windows gcp linux gcp windows
💚​ TestAccept 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
Top 3 slowest tests (at least 2 minutes):
duration env testname
3:23 gcp windows TestAccept
3:20 aws windows TestAccept
3:11 azure windows TestAccept

@andrewnester
andrewnester requested a review from denik September 15, 2026 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants