Skip to content

[coverage] Conformance findings: SESSION-017 #481

Description

@peco-engineer-bot

Summary

Surfaced by the multi-language coverage fan-out while conformance-testing these SPEC-IDs against databricks/databricks-sql-go. Each finding is committed as an expected-failure (xfail) test in the coverage PR — the test asserts the CORRECT (post-fix) behavior and stays red until THIS driver (databricks/databricks-sql-go) is fixed, then flips green as a tripwire.

Findings

  • SESSION-017 [thrift]: A malformed enableTelemetry DSN value is fatal: ParseDSN rejects the entire DSN (strconv.ParseBool error) so the connection never opens, instead of leaving the telemetry overlay default untouched and diagnosing the typo
    • failing test: TestTelemetryEnablementPropertyIsHonoredAndOptional (see the coverage PR diff under tests/)

Reproduce & Expected

SESSION-017 — Validates the connect-time contract of the driver's telemetry-enablement connection property (reference ODBC key EnableTelemetry; map to the driver's own spelling for the SAME concept, e.g.

Reproduce:

SELECT 1 AS value
SELECT 1 AS value
SELECT 1 AS value
SELECT 1 AS value

Expected (per the shared spec):

  • completes without an exception
  • result has exactly 1 row(s)
  • col 0 is named value
  • completes without an exception
  • result has exactly 1 row(s)
  • completes without an exception
  • result has exactly 1 row(s)
  • completes without an exception
  • result has exactly 1 row(s)
  • full assertion contract:
result:
- label: opt_in
  no_exception: true
- label: opt_in
  row_count: 1
- label: opt_in
  column:
    index: 0
    name: value
- label: opt_in
  warning_diagnostic:
    mentions: EnableTelemetry
    present: false
- label: opt_out
  no_exception: true
- label: opt_out
  row_count: 1
- label: opt_out
  warning_diagnostic:
    mentions: EnableTelemetry
    present: false
- label: malformed
  no_exception: true
- label: malformed
  row_count: 1
- label: malformed
  warning_diagnostic:
    mentions: EnableTelemetry
    present: true
    sql_state: 01S02
- label: absent
  no_exception: true
- label: absent
  row_count: 1

Context

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions