Revert update Apache Arrow to v16 - #228
Merged
Merged
Conversation
kravets-levko
requested review from
andrefurlan-db,
jadewang-db,
rcypher-databricks and
yunbodeng-db
as code owners
June 4, 2024 22:12
yunbodeng-db
approved these changes
Jun 4, 2024
Contributor
|
Hi @kravets-levko! |
Contributor
Author
|
Hi @candiduslynx! Yes, we indeed plan to re-do the upgrade at some point. But we are looking for the way to do this and avoid issues for our users. We don't expect any major changes to the library in nearest future, so you can continue using |
atzoum
pushed a commit
to rudderlabs/sqlconnect-go
that referenced
this pull request
Jul 4, 2024
….5.6 to 1.5.7 (#93) Bumps [github.com/databricks/databricks-sql-go](https://github.com/databricks/databricks-sql-go) from 1.5.6 to 1.5.7. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/databricks/databricks-sql-go/releases">github.com/databricks/databricks-sql-go's releases</a>.</em></p> <blockquote> <h2>v1.5.7</h2> <ul> <li><code>databricks/databricks-sql-go#228</code></li> <li><code>databricks/databricks-sql-go#227</code></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/databricks/databricks-sql-go/blob/main/CHANGELOG.md">github.com/databricks/databricks-sql-go's changelog</a>.</em></p> <blockquote> <h2>v1.5.7 (2024-06-05)</h2> <ul> <li><code>databricks/databricks-sql-go#228</code></li> <li><code>databricks/databricks-sql-go#227</code></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/databricks/databricks-sql-go/commit/5d3c3d7d2fb5bd36181e306e893fc8040326a1fe"><code>5d3c3d7</code></a> Prepare release v1.5.7 (<a href="https://redirect.github.com/databricks/databricks-sql-go/issues/229">#229</a>)</li> <li><a href="https://github.com/databricks/databricks-sql-go/commit/6ec1955fcecd71e7e19e2b17ac3a394181965af0"><code>6ec1955</code></a> Add more debug logging for CloudFetch (<a href="https://redirect.github.com/databricks/databricks-sql-go/issues/227">#227</a>)</li> <li><a href="https://github.com/databricks/databricks-sql-go/commit/869c98e75049f92f3c93379fd9f086c9335f1fb9"><code>869c98e</code></a> Revert update Apache Arrow to <code>v16</code> (<a href="https://redirect.github.com/databricks/databricks-sql-go/issues/228">#228</a>)</li> <li>See full diff in <a href="https://github.com/databricks/databricks-sql-go/compare/v1.5.6...v1.5.7">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
|
Is there any place that mentions the breaking changes? |
Contributor
|
Is this still on v12? |
4 tasks
TangoEnSkai
added a commit
to TangoEnSkai/databricks-sql-go
that referenced
this pull request
Sep 9, 2026
…Func) Arrow v12's TimestampType.GetToTimeFunc lazily caches the type's *time.Location via GetZone without synchronization (apache/arrow#38795, fixed only in later Arrow versions the driver cannot move to yet, see issue databricks#228). NewArrowRowScanner calls GetToTimeFunc on the shared arrow.FixedWidthTypes.Timestamp_us singleton for every result set, so concurrent queries race on that first call, as reported in issue databricks#179. Warm the cache for all four shared fixed-width timestamp singletons in a package init, before any concurrency is possible, so every later call is a plain read. This is the same workaround users currently have to apply in their own code; doing it in the driver removes the need to import Arrow (a transitive dependency) just to use databricks-sql-go safely from multiple goroutines. The new regression test fails under the race detector if the init is removed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: TangoEnSkai <21152231+TangoEnSkai@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #216
Unfortunately, updating Apache Arrow turned out to be a breaking change which created issues to some library users. We made a decision to revert this upgrade