Conversation
Signed-off-by: cat23123 <58714163+cat23123@users.noreply.github.com>
cathleeny
marked this pull request as ready for review
September 15, 2026 20:01
There was a problem hiding this comment.
Verdict: 1 Medium
Looks solid — thorough tests and documentation for the new WithClientQueryTimeout kernel option; config plumbing, DeepCopy, sentinel wiring, and the C-ABI max constant are all correct and covered. One medium concurrency concern: the detached-watcher path inverts the legacy canceller-before-statement teardown ordering, whose safety rests on a kernel contract not verifiable from this repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WithClientQueryTimeoutfor the SEA/kernel backend.kernel_statement_execute_with_timeout_ms; zero and maximumtime.Durationare unlimited.WithTimeoutremains the independent server-side Thrift option.Depends on databricks-sql-kernel#339 at
ec639bd48e84c64d708a0b70a532e44ecf83ad7c; updated kernel bindings are required before release.Validation
HYT00in 5.002s, then successfully reused the samesql.ConnforSELECT 1