Define a mantra#4
Merged
Merged
Conversation
dimitri-yatsenko
approved these changes
Sep 29, 2022
guzman-raphael
pushed a commit
that referenced
this pull request
Oct 21, 2022
Add youtube links. DesignPrinciples -> Concepts
4 tasks
4 tasks
dimitri-yatsenko
added a commit
that referenced
this pull request
Jun 5, 2026
Fixes for items #2 and #4 from her review: - storage-adapter-api.md: removed the "Built-in adapters" section and the claim that file/s3/gcs/azure protocols are themselves StorageAdapter subclasses. In v2.2.3 those protocols are still served by the existing StorageBackend._create_filesystem() dispatch; migrating them onto the public adapter contract is tracked separately. - storage-adapter-api.md: added an "Available in datajoint ≥ 2.2.4" note near the StorageAdapter base-class introduction. dj.StorageAdapter / dj.get_storage_adapter() are not exported in 2.2.3; a paired datajoint-python PR adds the exports for 2.2.4. - whats-new-2-2-3.md: reframed the "Storage-adapter plugin contract" section to match — the contract is for third-party adapters; built-ins continue via internal dispatch. - manage-secrets.md: corrected the lone remaining DJ_TLS=true → DJ_USE_TLS=true in the env-var example (line 88). Items #3 (settings.py "New in 2.3" markers) and #1 (StorageAdapter export) are addressed by separate datajoint-python PRs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.