Skip to content

genSaltSync accepts a non-integer cost and returns a salt that hashSync rejects #173

Description

@MildlyMeticulous

genSaltSync clamps the cost range but never checks it is an integer, so a fractional cost is formatted straight into the salt:

const bcrypt = require('bcryptjs');   // 3.0.3

const salt = bcrypt.genSaltSync(10.5);   // '$2b$10.5$OT90lVUoKI5OXCk88A2Z0.'
bcrypt.hashSync('hunter2', salt);        // Error: Missing salt rounds

genSalt returns a value its own hash cannot consume. Other bad inputs are handled at the call: 3 and -1 clamp to 04, 'abc' throws. index.js:93-99 checks the range only:

if (rounds < 4) rounds = 4;
else if (rounds > 31) rounds = 31;
...
salt.push(rounds.toString());

Number(process.env.BCRYPT_ROUNDS) on "10.5" is enough to hit it. Async genSalt behaves the same.

The same missing check on the parsing side is #167, still reproducible on 3.0.3:

bcrypt.hashSync('hunter2', '$2a$xy$abcdefghijklmnopqrstuu');
// '$2a$NaN$abcdefghijklmnopqrstuu...'  61 chars, 0.14 ms against 280 ms for cost 12

parseInt gives NaN, the rounds < 4 || rounds > 31 guard passes because NaN comparisons are false, and 1 << NaN is 1. That one was closed by the stale bot rather than triaged. Number.isInteger on each side covers both.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions