test(e2e): fix the project-rename flake at its root and run the suite once

[tkislan]

Summary

Fixes the flaky projectRename E2E suite at its root and drops the expensive whole-suite retry. Surgical — 4 files.

• Runs once in CI. Removes the until … max=2 shell loop in e2e.yml that reran all 16 spec files on any failure.
• Fixes the actual flake. projectRename failed reproducibly deep in the shared run but passed in a fresh instance. leaveUnsavedCellEdit located the first code cell's .view-line then .click()d it as a separate step; the notebook re-renders its cells on open, staling that reference before the click lands (StaleElementReferenceError) — far likelier when the shared instance is sluggish late in the run. It now locates and clicks in one retried driver.wait step (the fix from feat(telemetry): add PostHog analytics for notebook usage events #375).
• Isolation. ExTester runs every spec in one shared VS Code instance, and no suite dismissed notification toasts in teardown, so they stacked up — waitForNotification polls every visible toast each tick, slowing later specs and overlapping the tree/menus/inputs they drive. A Mocha root afterEach (test/e2e/rootHooks.ts, wired via .mocharc.js) now dismisses them between tests.

Validation

Ran the full stack locally exactly as CI does — packaged the VSIX, downloaded test VS Code 1.111.0 + ChromeDriver, installed the built extension + the Python extension, under Xvfb:

• Full suite, single run: 54 passing, 0 failing, 1 pending (the intentional it.skip). projectRename passes in-place — it failed 2/2 full runs before this fix.
• npm run compile-e2e clean; npm run format-fix clean.

Known follow-up (not in this PR)

Running kernels/servers and global environments created by the cell-running suites are not torn down between suites. The run is green despite this now that the race is fixed, but fully isolating them means per-suite environment teardown, which re-provisions venvs and adds CI time — a separate cost/isolation decision.

🤖 Generated with Claude Code

https://claude.ai/code/session_01ELgnvYGB68gTtHncpWN588

Summary by CodeRabbit

• Bug Fixes

  • Improved reliability when editing unsaved notebook cells during project renaming.
  • Prevented notification messages from lingering between end-to-end test scenarios.

• Tests

  • Streamlined end-to-end test execution and improved handling of transient interface updates.
  • Enhanced test setup to consistently reset notifications and use compiled test configuration.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0%. Comparing base (b8505b2) to head (79bb170).
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@     Coverage Diff     @@
##   main   #443   +/-   ##
===========================
===========================

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[tkislan]

@coderabbitai full review

[coderabbitai]

✅ Action performed

Full review finished.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 60408c96-8ae1-4ed1-8403-8f81235c0e3e

📥 Commits

Reviewing files that changed from the base of the PR and between b8505b2 and 79bb170.

📒 Files selected for processing (4)

• .github/workflows/e2e.yml
• test/e2e/.mocharc.js
• test/e2e/rootHooks.ts
• test/e2e/suite/projectRename.e2e.test.ts

---

📝 Walkthrough

Walkthrough

The E2E workflow now runs the prebuilt suite once under xvfb-run. Mocha loads compiled root hooks that dismiss notifications after each test. The project rename test also retries locating and clicking the first notebook code cell to tolerate transient re-rendering.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• deepnote/vscode-deepnote#430: Introduced the notification dismissal helper and related E2E setup changes.

🚥 Pre-merge checks | ✅ 6

✅ Passed checks (6 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately captures the main fix for the project-rename E2E flake and the switch to a single suite run.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Updates Docs	✅ Passed	Only CI/test files changed; no user-facing docs or roadmap content was touched, so this docs check is not applicable.

---

_{Comment @coderabbitai help to get the list of available commands.}