feat: Support self.close inside node workers#21
Merged
Conversation
guybedford
reviewed
Sep 30, 2021
addaleax
approved these changes
Sep 30, 2021
Co-authored-by: Guy Bedford <guybedford@gmail.com>
guybedford
reviewed
Sep 30, 2021
Contributor
Author
|
Thanks for the reviews @guybedford and @addaleax! Anything else I need to do to get this released? |
Contributor
Author
|
@developit Anything else you need here? |
Contributor
Author
|
@guybedford I noticed that you have publish permissions on npm. Can we get this merged and released? |
guybedford
approved these changes
Nov 4, 2021
Collaborator
|
@phated it is up to @developit to manage the releases here, it would be out of the usual process for me to do that. |
developit
approved these changes
Nov 5, 2021
Owner
|
Apologies for the delay! This is now published as web-worker@1.2.0. |
Contributor
Author
|
Thanks!!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the
self.close()function that is available in a Worker's global scope, as per https://developer.mozilla.org/en-US/docs/Web/API/DedicatedWorkerGlobalScope/close