[Devfile#1721] Adding renovate.json and test script to ensure sample can still be parsed and used by consumers for go sample#45
Merged
Conversation
thepetk
reviewed
Jul 24, 2025
thepetk
left a comment
thepetk
left a comment
Contributor
There was a problem hiding this comment.
I think this one better to be on hold until Michael's comment is resolved
devfile-samples/devfile-sample-python-basic#70 (review)
Most probably we need to follow the same logic here too.
thepetk
reviewed
Jul 24, 2025
thepetk
left a comment
thepetk
left a comment
Contributor
There was a problem hiding this comment.
A quick comment for the usage of stackDir
michael-valdron
left a comment
michael-valdron
left a comment
Contributor
There was a problem hiding this comment.
@JslYoon Can review once same changes as devfile/api#1718 are applied here.
Signed-off-by: Lucas Yoon <lyoon@lyoon-thinkpadp1gen7.boston.csb>
michael-valdron
requested changes
Jul 28, 2025
Signed-off-by: Lucas Yoon <lyoon@lyoon-thinkpadp1gen7.boston.csb>
michael-valdron
requested changes
Jul 28, 2025
Co-authored-by: Michael Valdron <michael.valdron@gmail.com>
Co-authored-by: Michael Valdron <michael.valdron@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Devfile#1721] Adding renovate.json and test script to ensure sample can still be parsed and used by consumers
devfile/api#1721
Adding renovate.json and test script to ensure sample can still be parsed and used by consumers.
tests include:
odov3
non-terminating
validate-devfile-schemas