Supports Windows 10 versions before 2004 - #402
Closed
wuwbobo2021 wants to merge 1 commit into
Closed
wuwbobo2021 wants to merge 1 commit into
wuwbobo2021 wants to merge 1 commit into
Conversation
Contributor
|
I'd really rather this be a conditional on the OS version rather then just throwing out the error completely, especially because this is such an old version of Win10. Also this needs comments for why it's happening. |
qdot
requested changes
Dec 21, 2024
qdot
left a comment
qdot
left a comment
Contributor
There was a problem hiding this comment.
Make this a conditional that parses OS version, because I want to throw an error whenever possible. Also, needs comments about why this is happening since it's done for a rare platform.
This comment was marked as off-topic.
This comment was marked as off-topic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes for this issue: #364.
Thanks to @ChristianPavilonis for providing the clue. He had forked this project and deleted the line that causes the problem.
This fix tries to keep the functionality as is, merely ignoring the returned error if
SetAllowExtendedAdvertisements()isn't available.