-
Notifications
You must be signed in to change notification settings - Fork 0
Fix Codex terminal link clicks and name the innerdogfood harness #581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
1c9438b
Rename standalone browser dev task to innerdogfood
nedtwigg 420bfb2
Fix terminal hyperlink clicks by deferring pointer capture
nedtwigg ea291b4
Simplify the deferred pointer capture and its docs
nedtwigg bdc3b97
Preserve scope and regression reference in testing guidance
nedtwigg 3e1a4bf
Capture mouse presses on xterm screen to preserve edge drags
nedtwigg ced9ba1
Add screen lookup to terminal registry test element
nedtwigg c587dbb
Drop unrelated mouse-router comment rewrap
nedtwigg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this leave two live webviews on one sidecar?
openAgentBrowser()runs unconditionally at the end ofstandalone/scripts/dev-agent-browser.mjsand doesagent-browser --session <browserSession> open http://localhost:${vitePort}— with the defaultsbrowserSession = 'dormouse-dev-standalone'andvitePort = 1420. So by the time the reader runsdor ab --key innerdogfood open http://localhost:1420, the harness has already opened that exact URL in its own session, and this line opens it again underdormouse.1.innerdogfood.Both pages then hold an SSE stream on the same bridge, and the bridge has no per-webview routing:
sseClientsis a plainSetandbroadcast()fans every sidecar event to all of it. That is the situationdocs/specs/transport.md-> "PTY ownership" is about — "A PTY routed to one webview must not be stolen by another router; new routers attaching to a host must respect existing ownership" — and the dev bridge is the one host that doesn't enforce it.The repo's own
debug-standalone-agent-browserskill goes the other way: "Use the outer harness session printed byinnerdogfood", i.e. drive the session the harness already opened rather than starting a second one.dor ab --session dormouse-dev-standalone <cmd>is the flag for that — perdor ab --help, "Attach to a raw agent-browser session by its literal name", and "dor opens (or reuses) the browser surface bound to the session" — which would put the harness's existing page in a Dormouse pane without a second webview.If you exercised the two-browser form while validating the Codex link click and it behaves, say so and I'll drop it — I can't run the harness from CI. But as written, AGENTS.md and the skill now prescribe different things for the same task.