Skip to content

Check if EditorConfig file exist for Ktlint in KotlinGradleExtension - #1889

Merged
nedtwigg merged 1 commit into
diffplug:mainfrom
Goooler:check-editorconfig-exist-for-kotlin-gradle
Nov 20, 2023
Merged

Check if EditorConfig file exist for Ktlint in KotlinGradleExtension#1889
nedtwigg merged 1 commit into
diffplug:mainfrom
Goooler:check-editorconfig-exist-for-kotlin-gradle

Conversation

@Goooler

@Goooler Goooler commented Nov 18, 2023

Copy link
Copy Markdown
Member

I missed this in #1788.

@Goooler
Goooler force-pushed the check-editorconfig-exist-for-kotlin-gradle branch from fdb85bf to 2ff556b Compare November 18, 2023 17:49
@Goooler Goooler changed the title Check if EditorConfig file exist for Ktlint in KotlinGradleExtension Check if EditorConfig file exist for Ktlint in KotlinGradleExtension Nov 18, 2023
@Goooler

Goooler commented Nov 18, 2023

Copy link
Copy Markdown
Member Author

This had been finished in the Maven plugin at

configPath = ThrowingEx.get(() -> FileSignature.signAsList(stepConfig.getFileLocator().locateFile(editorConfigPath)));

right?

@nedtwigg

Copy link
Copy Markdown
Member

Yep, signAsList throws an error message on its own, but writing it out explicitly as you did in this PR is good too.

@Goooler
Goooler deleted the check-editorconfig-exist-for-kotlin-gradle branch November 20, 2023 17:55
@nedtwigg

Copy link
Copy Markdown
Member

Released in plugin-gradle 6.23.0 and plugin-maven 2.41.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants