ci: upstream docs conformance validation - #1218
Merged
Merged
Conversation
crazy-max
force-pushed
the
validate-docs-upstream
branch
from
July 19, 2022 17:25
7db4da9 to
2966018
Compare
crazy-max
marked this pull request as draft
July 19, 2022 17:29
crazy-max
force-pushed
the
validate-docs-upstream
branch
4 times, most recently
from
July 30, 2022 23:01
d19ebd8 to
e57937d
Compare
crazy-max
marked this pull request as ready for review
July 30, 2022 23:06
jedevc
approved these changes
Aug 1, 2022
tonistiigi
reviewed
Aug 1, 2022
tonistiigi
left a comment
Member
There was a problem hiding this comment.
Does this tool actually pull down all the URLs (comments could help).
If it does could we filter this to only run on master or if *.md changes etc.
crazy-max
force-pushed
the
validate-docs-upstream
branch
from
August 2, 2022 00:49
e57937d to
b39ada8
Compare
Member
Author
Yes it will run the validation for the whole docs repo as cross links could be broken outside our scope so we can take that into account and react accordingly (here or on docs repo).
Done Also added reference yaml docs that was not covered in the validation and we have a dead link: https://github.com/docker/buildx/runs/7622740288?check_suite_focus=true#step:8:667 Fixed with last commit. |
crazy-max
force-pushed
the
validate-docs-upstream
branch
3 times, most recently
from
August 2, 2022 18:54
def27c3 to
69be01f
Compare
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
validate-docs-upstream
branch
from
August 2, 2022 19:22
69be01f to
cceb1ac
Compare
tonistiigi
approved these changes
Aug 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
needs docker/docs#14905 or docker/docs#15194adds a job to check if links are still valid with upstream docs repository.
Signed-off-by: CrazyMax crazy-max@users.noreply.github.com