Replace gometalinter with Golangci lint by silvin-lubecki · Pull Request #1797 · docker/cli

opts/throttledevice.go:51:5: SA4003: unsigned values are never < 0 (staticcheck)

silvin-lubecki

committed

c38ca4c

cli/command/trust/inspect_pretty_test.go:399:24: SA4010: this result of append is never used, except maybe in other appends (staticcheck)

silvin-lubecki

committed

65808fc

cli/command/container/stats.go:211:21: SA1015: using time.Tick leaks the underlying ticker, consider using it only in endless functions, tests and the main package, and use time.NewTicker here (sta…

silvin-lubecki

committed

b2158b2

SA1019: httputil.ErrPersistEOF is deprecated: No longer used. (staticcheck)

silvin-lubecki

committed

fcbd937

cli/command/trust/key_generate.go:112:9: nilness: impossible condition: nil != nil (govet)

silvin-lubecki

committed

63bf41f

cli/command/stack/kubernetes/list.go:32:47: nilness: tautological condition: non-nil != nil (govet)

silvin-lubecki

committed

0d5c8d0

cli/command/container/start.go:157:20: nilness: nil dereference in type assertion (govet)

silvin-lubecki

committed

27ebbbe

cli/registry/client/fetcher.go:106:9: nilness: impossible condition: nil != nil (govet)

silvin-lubecki

committed

68a8b2c

cli/compose/types/types.go:106:2: structtag: struct field tag `yaml:",inline", json:"-"` not compatible with reflect.StructTag.Get: key:"value" pairs not separated by spaces (govet)

silvin-lubecki

committed

31e233b

opts/ulimit_test.go:11:13: composites: `*github.com/docker/cli/vendor/github.com/docker/go-units.Ulimit` composite literal uses unkeyed fields (govet)

silvin-lubecki

committed

0850214

cli/command/container/attach.go:141:15: nilness: impossible condition: nil != nil (govet)

silvin-lubecki

committed

2fc15a6

unchecked errors

silvin-lubecki

committed

d5bbb94

cli/command/image/build/context_test.go:244:38: `createTestTempDir` - `dir` always receives `""` (unparam)

silvin-lubecki

committed

3c4788a

cli/command/image/build/context_test.go:252:71: `createTestTempFile` - `perm` always receives `0777` (`511`) (unparam)

silvin-lubecki

committed

321aff9

cli/command/image/build_buildkit.go:450:56: parseSSH - result 1 (error) is always nil (unparam)

silvin-lubecki

committed

216bedc

cli/command/image/build_session.go:133:45: getBuildSharedKey - result 1 (error) is always nil (unparam)

silvin-lubecki

committed

5abbbfc

cli/command/plugin/list_test.go:61:31: `TestList$1` - `filter` is unused (unparam)

silvin-lubecki

committed

65237e7

cli/command/stack/kubernetes/deploy_test.go:65:68: `checkOwnerReferences` - `stackName` always receives `"test"` (unparam)

silvin-lubecki

committed

8f98106

cli/command/system/info.go:116:68: prettyPrintClientInfo - result 0 (error) is always nil (unparam)

silvin-lubecki

committed

d110697

cli/compose/convert/service.go:592:76: convertDNSConfig - result 1 (error) is always nil (unparam)

silvin-lubecki

committed

c014ec1

disable unparam linter on these functions, as we need an error in these function signatures

silvin-lubecki

committed

7a47e81

cli/context/kubernetes/endpoint_test.go:122:38: `checkClientConfig` - `s` is unused (unparam)

silvin-lubecki

committed

2f09e17

Disable unparam linter: cli/required.go:102:16: `pluralize` - `word` always receives `"argument"` (unparam)

silvin-lubecki

committed

f443ad3

Disable unparam linter: e2e/image/push_test.go:299:27: `withNotaryPassphrase` - `pwd` always receives `"foo"` (unparam)

silvin-lubecki

committed

02091c1

cli/command/trust/sign_test.go:119:70: unnecessary conversion (unconvert)

silvin-lubecki

committed

cd030a1

File is not `goimports`-ed (goimports)

silvin-lubecki

committed

4a7a541

cli/compose/convert/service_test.go:274:72: unnecessary conversion (unconvert)

silvin-lubecki

committed

54cab47

cli/command/registry/login_test.go:66:25: unnecessary conversion (unconvert)

silvin-lubecki

committed

06908e0

cli/command/image/build/context_test.go:244:38: `createTestTempDir` - `prefix` always receives `"builder-context-test"` (unparam)

silvin-lubecki

committed

e62ed7a

Remove now obsolete gometalinter and use golangci-lint instead with almost the same configuration.

silvin-lubecki

committed

fbf90f3

Navigation Menu

Uh oh!

Replace gometalinter with Golangci lint - #1797

Replace gometalinter with Golangci lint#1797
silvin-lubecki wants to merge 30 commits into
docker:masterfrom
silvin-lubecki:golangci-lint

Commits on Apr 2, 2019

opts/throttledevice.go:51:5: SA4003: unsigned values are never < 0 (staticcheck)

cli/command/trust/inspect_pretty_test.go:399:24: SA4010: this result of append is never used, except maybe in other appends (staticcheck)

cli/command/container/stats.go:211:21: SA1015: using time.Tick leaks the underlying ticker, consider using it only in endless functions, tests and the main package, and use time.NewTicker here (sta…

SA1019: httputil.ErrPersistEOF is deprecated: No longer used. (staticcheck)

cli/command/trust/key_generate.go:112:9: nilness: impossible condition: nil != nil (govet)

cli/command/stack/kubernetes/list.go:32:47: nilness: tautological condition: non-nil != nil (govet)

cli/command/container/start.go:157:20: nilness: nil dereference in type assertion (govet)

cli/registry/client/fetcher.go:106:9: nilness: impossible condition: nil != nil (govet)

cli/compose/types/types.go:106:2: structtag: struct field tag `yaml:",inline", json:"-"` not compatible with reflect.StructTag.Get: key:"value" pairs not separated by spaces (govet)

opts/ulimit_test.go:11:13: composites: `*github.com/docker/cli/vendor/github.com/docker/go-units.Ulimit` composite literal uses unkeyed fields (govet)

cli/command/container/attach.go:141:15: nilness: impossible condition: nil != nil (govet)

unchecked errors

cli/command/image/build/context_test.go:244:38: `createTestTempDir` - `dir` always receives `""` (unparam)

cli/command/image/build/context_test.go:252:71: `createTestTempFile` - `perm` always receives `0777` (`511`) (unparam)

cli/command/image/build_buildkit.go:450:56: parseSSH - result 1 (error) is always nil (unparam)

cli/command/image/build_session.go:133:45: getBuildSharedKey - result 1 (error) is always nil (unparam)

cli/command/plugin/list_test.go:61:31: `TestList$1` - `filter` is unused (unparam)

cli/command/stack/kubernetes/deploy_test.go:65:68: `checkOwnerReferences` - `stackName` always receives `"test"` (unparam)

cli/command/system/info.go:116:68: prettyPrintClientInfo - result 0 (error) is always nil (unparam)

cli/compose/convert/service.go:592:76: convertDNSConfig - result 1 (error) is always nil (unparam)

disable unparam linter on these functions, as we need an error in these function signatures

cli/context/kubernetes/endpoint_test.go:122:38: `checkClientConfig` - `s` is unused (unparam)

Disable unparam linter: cli/required.go:102:16: `pluralize` - `word` always receives `"argument"` (unparam)

Disable unparam linter: e2e/image/push_test.go:299:27: `withNotaryPassphrase` - `pwd` always receives `"foo"` (unparam)

cli/command/trust/sign_test.go:119:70: unnecessary conversion (unconvert)

File is not `goimports`-ed (goimports)

cli/compose/convert/service_test.go:274:72: unnecessary conversion (unconvert)

cli/command/registry/login_test.go:66:25: unnecessary conversion (unconvert)

cli/command/image/build/context_test.go:244:38: `createTestTempDir` - `prefix` always receives `"builder-context-test"` (unparam)

Remove now obsolete gometalinter and use golangci-lint instead with almost the same configuration.