Replace gometalinter with Golangci lint [carry 1797] - #2173

Merged

thaJeztah merged 61 commits into

docker:masterfrom

thaJeztah:carry_golangci_lint

Oct 31, 2019

Commits on Oct 31, 2019

opts/throttledevice.go:51:5: SA4003: unsigned values are never < 0 (staticcheck)

silvin-lubecki
authored and
thaJeztah
committed
2962971
cli/command/trust/inspect_pretty_test.go:399:24: SA4010: this result of append is never used, except maybe in other appends (staticcheck)

silvin-lubecki
authored and
thaJeztah
committed
8018a85
cli/command/container/stats.go:211:21: SA1015: using time.Tick leaks the underlying ticker, consider using it only in endless functions, tests and the main package, and use time.NewTicker here (sta…

silvin-lubecki
authored and
thaJeztah
committed
7da9360
SA1019: httputil.ErrPersistEOF is deprecated: No longer used. (staticcheck)

silvin-lubecki
authored and
thaJeztah
committed
3a42820
cli/command/trust/key_generate.go:112:9: nilness: impossible condition: nil != nil (govet)

silvin-lubecki
authored and
thaJeztah
committed
f5e8387
cli/command/stack/kubernetes/list.go:32:47: nilness: tautological condition: non-nil != nil (govet)

silvin-lubecki
authored and
thaJeztah
committed
85cfd4e
cli/command/container/start.go:157:20: nilness: nil dereference in type assertion (govet)

silvin-lubecki
authored and
thaJeztah
committed
9afeb6f
cli/registry/client/fetcher.go:106:9: nilness: impossible condition: nil != nil (govet)

silvin-lubecki
authored and
thaJeztah
committed
5ceed30
cli/compose/types/types.go:106:2: structtag: struct field tag `yaml:",inline", json:"-"` not compatible with reflect.StructTag.Get: key:"value" pairs not separated by spaces (govet)

silvin-lubecki
authored and
thaJeztah
committed
1bfe813
opts/ulimit_test.go:11:13: composites: `*github.com/docker/cli/vendor/github.com/docker/go-units.Ulimit` composite literal uses unkeyed fields (govet)

silvin-lubecki
authored and
thaJeztah
committed
b3d4c6a
cli/command/container/attach.go:141:15: nilness: impossible condition: nil != nil (govet)

silvin-lubecki
authored and
thaJeztah
committed
584da37
unchecked errors

silvin-lubecki
authored and
thaJeztah
committed
e1c0c79
cli/command/image/build/context_test.go:244:38: `createTestTempDir` - `dir` always receives `""` (unparam)

silvin-lubecki
authored and
thaJeztah
committed
70bd64d
cli/command/image/build/context_test.go:252:71: `createTestTempFile` - `perm` always receives `0777` (`511`) (unparam)

silvin-lubecki
authored and
thaJeztah
committed
0ce2eae
cli/command/image/build_buildkit.go:450:56: parseSSH - result 1 (error) is always nil (unparam)

silvin-lubecki
authored and
thaJeztah
committed
28ac2f8
cli/command/image/build_session.go:133:45: getBuildSharedKey - result 1 (error) is always nil (unparam)

silvin-lubecki
authored and
thaJeztah
committed
75c60c1
cli/command/plugin/list_test.go:61:31: `TestList$1` - `filter` is unused (unparam)

silvin-lubecki
authored and
thaJeztah
committed
ab1aeed
cli/command/stack/kubernetes/deploy_test.go:65:68: `checkOwnerReferences` - `stackName` always receives `"test"` (unparam)

silvin-lubecki
authored and
thaJeztah
committed
a3c7cb4
cli/command/system/info.go:116:68: prettyPrintClientInfo - result 0 (error) is always nil (unparam)

silvin-lubecki
authored and
thaJeztah
committed
47741f8
cli/compose/convert: result 1 (error) is always nil (unparam)

silvin-lubecki
authored and
thaJeztah
committed
d640f44
disable unparam linter on these functions, as we need an error in these function signatures

silvin-lubecki
authored and
thaJeztah
committed
6eb0c9c
compose/loader: define type for transformer-functions
thaJeztah
committed
9118b2b
Disable unparam linter: cli/required.go:102:16: `pluralize` - `word` always receives `"argument"` (unparam)

silvin-lubecki
authored and
thaJeztah
committed
7d82343
Disable unparam linter: e2e/image/push_test.go:299:27: `withNotaryPassphrase` - `pwd` always receives `"foo"` (unparam)

silvin-lubecki
authored and
thaJeztah
committed
f123e43
cli/command/trust/sign_test.go:119:70: unnecessary conversion (unconvert)

silvin-lubecki
authored and
thaJeztah
committed
0153624
File is not `goimports`-ed (goimports)

silvin-lubecki
authored and
thaJeztah
committed
6047259
cli/compose/convert/service_test.go:274:72: unnecessary conversion (unconvert)

silvin-lubecki
authored and
thaJeztah
committed
c237379
cli/command/registry/login_test.go:66:25: unnecessary conversion (unconvert)

silvin-lubecki
authored and
thaJeztah
committed
4be924a
cli/command/image/build/context_test.go:244:38: `createTestTempDir` - `prefix` always receives `"builder-context-test"` (unparam)

silvin-lubecki
authored and
thaJeztah
committed
b83545e
e2e/container: containerExistsWithStatus - t is unused (unparam)
thaJeztah
committed
6205ef3
cli/compose/convert: driverObjectConfig - result 1 (error) is always nil (unparam)
thaJeztah
committed
34f5959
cli/command/secret: G101: Potential hardcoded credentials (gosec)
thaJeztah
committed
1850a05
cli/command/service: SA1012: do not pass a nil Context (staticcheck)
thaJeztah
committed
8d64c2a
cli/command/image/build: G107: Potential HTTP request made with variable url (gosec)
thaJeztah
committed
0e4bd30
cli/command/trust: SA1006: printf-style with no further arguments (staticcheck)
thaJeztah
committed
f0614ca
cli/command/utils: SA1006: printf-style with no further arguments (staticcheck)
thaJeztah
committed
ea64a1c
cli/command/image: SA1006: printf-style with no further arguments (staticcheck)
thaJeztah
committed
709728e
cli/context/store: SA5001: should check returned error before deferring f.Close() (staticcheck)
thaJeztah
committed
fe3cc6e
cli/command/formatter: Error return value of `ImageWrite` is not checked (errcheck)
thaJeztah
committed
9275e2c
cli/command: Error return value of `cli.Apply` is not checked (errcheck)
thaJeztah
committed
008f6a2
cli/command/formatter: Error return value of `ContainerWrite` is not checked (errcheck)
thaJeztah
committed
e74e2c7
cli/config: Using the variable on range scope `tc` in function literal (scopelint)
thaJeztah
committed
5a2a9d9
service/logs: Using the variable on range scope `testcase` in function literal (scopelint)
thaJeztah
committed
c828fa1
templates: Using the variable on range scope `testCase` in function literal (scopelint)
thaJeztah
committed
54d48de
cli/compose/loader: Using a reference for the variable on range scope `overrideService` (scopelint)
thaJeztah
committed
96ec729
e2e/cli-plugins: Using the variable on range scope `args` in function literal (scopelint)
thaJeztah
committed
1736662
cli/command/context: Using the variable on range scope `c` in function literal (scopelint)
thaJeztah
committed
a269e17
cli/command/trust: Using the variable on range scope `keyBytes` in function literal (scopelint)
thaJeztah
committed
7c4b63b
cli/command: Using the variable on range scope `testcase` in function literal (scopelint)
thaJeztah
committed
2ec424a
cli: remove unnecessary newlines (whitespace)
thaJeztah
committed
612d83d
internal: remove unnecessary newlines (whitespace)
thaJeztah
committed
63e45e6
e2e: remove unnecessary trailing newline (whitespace)
thaJeztah
committed
dd4d216
cli/command/container: suppress dogsled warnings
thaJeztah
committed
79dc83e
cli/compose/template: Using the variable on range scope `tc` in function literal (scopelint)
thaJeztah
committed
aafe3df
cli/manifest: Using the variable on range scope `testcase` in function literal (scopelint)
thaJeztah
committed
cd3dca3
opts: Using the variable on range scope `tc` in function literal (scopelint)
thaJeztah
committed
c2b069f
cli/command/stack/kubernetes: Using a reference for the variable on range scope `obj` (scopelint)
thaJeztah
committed
754fc6f
cli/command/container: Using the variable on range scope `c` in function literal (scopelint)
thaJeztah
committed
542f802
cli/command/stack/kubernetes: Using the variable on range scope `c` in function literal (scopelint)
thaJeztah
committed
640305f
service: remove unused opts from newService() (unparam)
thaJeztah
committed
1e77742
Remove now obsolete gometalinter and use golangci-lint instead

silvin-lubecki
authored and
thaJeztah
committed
b7e06f2