[19.03 backport] Replace gometalinter with Golangci lint [carry 1797] - #2239

Merged

silvin-lubecki merged 63 commits into

docker:19.03from

thaJeztah:19.03_backport_carry_golangci_lint

Jan 6, 2020

Commits on Jan 6, 2020

gometalinter: fix configuration
thaJeztah
committed
d85a3b2
Gometalinter: raise deadline to 3 minutes
thaJeztah
committed
3bc713c
compose/loader: fix TestIsAbs not testing all combinations
thaJeztah
committed
b71d5e3
opts/throttledevice.go:51:5: SA4003: unsigned values are never < 0 (staticcheck)

silvin-lubecki
authored and
thaJeztah
committed
ad7bd82
cli/command/trust/inspect_pretty_test.go:399:24: SA4010: this result of append is never used, except maybe in other appends (staticcheck)

silvin-lubecki
authored and
thaJeztah
committed
1ed4e67
cli/command/container/stats.go:211:21: SA1015: using time.Tick leaks the underlying ticker, consider using it only in endless functions, tests and the main package, and use time.NewTicker here (sta…

silvin-lubecki
authored and
thaJeztah
committed
49ff9c8
SA1019: httputil.ErrPersistEOF is deprecated: No longer used. (staticcheck)

silvin-lubecki
authored and
thaJeztah
committed
60aa890
cli/command/trust/key_generate.go:112:9: nilness: impossible condition: nil != nil (govet)

silvin-lubecki
authored and
thaJeztah
committed
fe1a85f
cli/command/stack/kubernetes/list.go:32:47: nilness: tautological condition: non-nil != nil (govet)

silvin-lubecki
authored and
thaJeztah
committed
cdc9d10
cli/command/container/start.go:157:20: nilness: nil dereference in type assertion (govet)

silvin-lubecki
authored and
thaJeztah
committed
c833341
cli/registry/client/fetcher.go:106:9: nilness: impossible condition: nil != nil (govet)

silvin-lubecki
authored and
thaJeztah
committed
66b760d
cli/compose/types/types.go:106:2: structtag: struct field tag `yaml:",inline", json:"-"` not compatible with reflect.StructTag.Get: key:"value" pairs not separated by spaces (govet)

silvin-lubecki
authored and
thaJeztah
committed
0f72909
opts/ulimit_test.go:11:13: composites: `*github.com/docker/cli/vendor/github.com/docker/go-units.Ulimit` composite literal uses unkeyed fields (govet)

silvin-lubecki
authored and
thaJeztah
committed
7d9b95d
cli/command/container/attach.go:141:15: nilness: impossible condition: nil != nil (govet)

silvin-lubecki
authored and
thaJeztah
committed
c8c1420
unchecked errors

silvin-lubecki
authored and
thaJeztah
committed
1f3468b
cli/command/image/build/context_test.go:244:38: `createTestTempDir` - `dir` always receives `""` (unparam)

silvin-lubecki
authored and
thaJeztah
committed
6f91e46
cli/command/image/build/context_test.go:252:71: `createTestTempFile` - `perm` always receives `0777` (`511`) (unparam)

silvin-lubecki
authored and
thaJeztah
committed
9c7b701
cli/command/image/build_buildkit.go:450:56: parseSSH - result 1 (error) is always nil (unparam)

silvin-lubecki
authored and
thaJeztah
committed
20ae2a6
cli/command/image/build_session.go:133:45: getBuildSharedKey - result 1 (error) is always nil (unparam)

silvin-lubecki
authored and
thaJeztah
committed
a3912a4
cli/command/plugin/list_test.go:61:31: `TestList$1` - `filter` is unused (unparam)

silvin-lubecki
authored and
thaJeztah
committed
a1f67cc
cli/command/stack/kubernetes/deploy_test.go:65:68: `checkOwnerReferences` - `stackName` always receives `"test"` (unparam)

silvin-lubecki
authored and
thaJeztah
committed
7db8c83
cli/command/system/info.go:116:68: prettyPrintClientInfo - result 0 (error) is always nil (unparam)

silvin-lubecki
authored and
thaJeztah
committed
9ac043b
cli/compose/convert: result 1 (error) is always nil (unparam)

silvin-lubecki
authored and
thaJeztah
committed
67a7fe0
disable unparam linter on these functions, as we need an error in these function signatures

silvin-lubecki
authored and
thaJeztah
committed
c77f525
compose/loader: define type for transformer-functions
thaJeztah
committed
b49a07b
Disable unparam linter: cli/required.go:102:16: `pluralize` - `word` always receives `"argument"` (unparam)

silvin-lubecki
authored and
thaJeztah
committed
c749704
Disable unparam linter: e2e/image/push_test.go:299:27: `withNotaryPassphrase` - `pwd` always receives `"foo"` (unparam)

silvin-lubecki
authored and
thaJeztah
committed
315715e
cli/command/trust/sign_test.go:119:70: unnecessary conversion (unconvert)

silvin-lubecki
authored and
thaJeztah
committed
03dbef8
cli/compose/convert/service_test.go:274:72: unnecessary conversion (unconvert)

silvin-lubecki
authored and
thaJeztah
committed
2441946
File is not `goimports`-ed (goimports)

silvin-lubecki
authored and
thaJeztah
committed
b2f6b49
cli/command/registry/login_test.go:66:25: unnecessary conversion (unconvert)

silvin-lubecki
authored and
thaJeztah
committed
44c8cec
cli/command/image/build/context_test.go:244:38: `createTestTempDir` - `prefix` always receives `"builder-context-test"` (unparam)

silvin-lubecki
authored and
thaJeztah
committed
98d2661
e2e/container: containerExistsWithStatus - t is unused (unparam)
thaJeztah
committed
7467a6a
cli/compose/convert: driverObjectConfig - result 1 (error) is always nil (unparam)
thaJeztah
committed
1a57296
cli/command/secret: G101: Potential hardcoded credentials (gosec)
thaJeztah
committed
c10bf24
cli/command/service: SA1012: do not pass a nil Context (staticcheck)
thaJeztah
committed
f969531
cli/command/image/build: G107: Potential HTTP request made with variable url (gosec)
thaJeztah
committed
acec6cb
cli/command/trust: SA1006: printf-style with no further arguments (staticcheck)
thaJeztah
committed
3bfa0f3
cli/command/utils: SA1006: printf-style with no further arguments (staticcheck)
thaJeztah
committed
50a23ed
cli/command/image: SA1006: printf-style with no further arguments (staticcheck)
thaJeztah
committed
fbe24f3
cli/context/store: SA5001: should check returned error before deferring f.Close() (staticcheck)
thaJeztah
committed
98150ae
cli/command/formatter: Error return value of `ImageWrite` is not checked (errcheck)
thaJeztah
committed
49253c7
cli/command: Error return value of `cli.Apply` is not checked (errcheck)
thaJeztah
committed
10fda07
cli/command/formatter: Error return value of `ContainerWrite` is not checked (errcheck)
thaJeztah
committed
bd778fc
cli/config: Using the variable on range scope `tc` in function literal (scopelint)
thaJeztah
committed
43b4988
service/logs: Using the variable on range scope `testcase` in function literal (scopelint)
thaJeztah
committed
a087595
templates: Using the variable on range scope `testCase` in function literal (scopelint)
thaJeztah
committed
ae7b1f7
cli/compose/loader: Using a reference for the variable on range scope `overrideService` (scopelint)
thaJeztah
committed
42ad244
e2e/cli-plugins: Using the variable on range scope `args` in function literal (scopelint)
thaJeztah
committed
0cab268
cli/command/context: Using the variable on range scope `c` in function literal (scopelint)
thaJeztah
committed
bda413e
cli/command/trust: Using the variable on range scope `keyBytes` in function literal (scopelint)
thaJeztah
committed
f7b23cf
cli: remove unnecessary newlines (whitespace)
thaJeztah
committed
b083f62
cli/command: Using the variable on range scope `testcase` in function literal (scopelint)
thaJeztah
committed
be5a3cc
internal: remove unnecessary newlines (whitespace)
thaJeztah
committed
09c9445
e2e: remove unnecessary trailing newline (whitespace)
thaJeztah
committed
65e0d7c
cli/command/container: suppress dogsled warnings
thaJeztah
committed
37ef1f5
cli/compose/template: Using the variable on range scope `tc` in function literal (scopelint)
thaJeztah
committed
fccc105
cli/manifest: Using the variable on range scope `testcase` in function literal (scopelint)
thaJeztah
committed
1b35214
opts: Using the variable on range scope `tc` in function literal (scopelint)
thaJeztah
committed
201e449
cli/command/stack/kubernetes: Using a reference for the variable on range scope `obj` (scopelint)
thaJeztah
committed
73dad43
cli/command/container: Using the variable on range scope `c` in function literal (scopelint)
thaJeztah
committed
b320fef
cli/command/stack/kubernetes: Using the variable on range scope `c` in function literal (scopelint)
thaJeztah
committed
e70edc3
Remove now obsolete gometalinter and use golangci-lint instead

silvin-lubecki
authored and
thaJeztah
committed
7374c0a