Skip to content

gordon: clarify Business tier activation via Settings Management#25153

Open
dvdksn wants to merge 1 commit into
docker:mainfrom
dvdksn:gordon-business-settings-mgmt
Open

gordon: clarify Business tier activation via Settings Management#25153
dvdksn wants to merge 1 commit into
docker:mainfrom
dvdksn:gordon-business-settings-mgmt

Conversation

@dvdksn
Copy link
Copy Markdown
Contributor

@dvdksn dvdksn commented May 22, 2026

Summary

The Business tier activation note in the Gordon prerequisites linked directly to the Admin Console configuration page but didn't signal that Settings Management as a whole needs to be properly set up for the policy to reach Docker Desktop clients. Updated step 2 to link to the top-level Settings Management page and note that its prerequisites must be met — deferring to that page as the canonical source rather than duplicating the details here.

Generated by Claude Code

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@netlify
Copy link
Copy Markdown

netlify Bot commented May 22, 2026

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 733c84e
🔍 Latest deploy log https://app.netlify.com/projects/docsdocker/deploys/6a10486dfe20fa00084c7887
😎 Deploy Preview https://deploy-preview-25153--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@dvdksn dvdksn added the status/review Pull requests that are ready for review label May 22, 2026
@dvdksn dvdksn requested a review from a team May 22, 2026 12:13
Copy link
Copy Markdown

@docker-agent docker-agent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🟢 APPROVE

The change is focused and accurate — it correctly redirects users to the top-level Settings Management page and adds a helpful prerequisite note. No high or medium issues found.

> [Admin Console](/manuals/enterprise/security/hardened-desktop/settings-management/configure-admin-console.md).
> Do not leave the setting at its default value, as this will not activate
> Gordon organization-wide.
> 2. Once confirmed, an organization administrator must enable Gordon via
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[LOW] Use "turn on" instead of "enable" per Docker style guide

The Docker word list specifies "turn on" / "toggle on" in place of "enable". Consider:

an organization administrator must turn on Gordon via

> Gordon organization-wide.
> 2. Once confirmed, an organization administrator must enable Gordon via
> [Settings Management](/manuals/enterprise/security/hardened-desktop/settings-management/).
> Set **Enable Gordon** to **Enabled** or **Always enabled**. Ensure all
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[LOW] Prefer positive framing over negative conditional

Per the Docker style guide, prefer positive language and avoid "otherwise X will not happen" constructions. Consider:

Ensure all Settings Management prerequisites are met for the setting to take effect on Docker Desktop clients.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ai status/review Pull requests that are ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants