Skip to content

Update underscore dependency to 1.8.3 - #204

Merged
jgonggrijp merged 1 commit into
documentcloud:masterfrom
bruun:update-underscore-1.8.3
Aug 24, 2020
Merged

Update underscore dependency to 1.8.3#204
jgonggrijp merged 1 commit into
documentcloud:masterfrom
bruun:update-underscore-1.8.3

Conversation

@bruun

@bruun bruun commented Sep 14, 2015

Copy link
Copy Markdown
Contributor

The current underscore dependency is over a year old,
this ensures that underscore-contrib is up-to-date.

I have verified that the test and dist tasks still
pass and run to completion.

The current underscore dependency is over a year old,
this ensures that underscore-contrib is up-to-date.

I have verified that the test and dist tasks still
pass and run to completion.
@jgonggrijp

Copy link
Copy Markdown
Contributor

To who takes up on this (possibly me): please start a new branch starting from the tip of bruun:update-underscore-1.8.3, merge in the latest changes from master, upgrade the underscore dependency again to the latest version, and finally submit a continuation PR. In this way, we get an up-to-date Underscore dependency and @bruun also gets credits for this work back in 2015.

@jgonggrijp jgonggrijp added the before modules This needs to be tackled before modularization (temporary label, see #220) label Aug 3, 2020
@jgonggrijp jgonggrijp linked an issue Aug 3, 2020 that may be closed by this pull request
@jgonggrijp
jgonggrijp marked this pull request as draft August 7, 2020 11:06
@jgonggrijp jgonggrijp self-assigned this Aug 24, 2020
@jgonggrijp
jgonggrijp merged commit 7bb8c22 into documentcloud:master Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

before modules This needs to be tackled before modularization (temporary label, see #220)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Updating to more recent underscore (1.8.x)

2 participants